London | May-2025 | Khilola_Rustamova | Module Structuring and Testing Data | Sprint 2 #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HilolaRustam
added
📅 Sprint 2
kodnificent
added
Review in progress
kodnificent
suggested changes
Jul 2, 2025
Sprint-2/1-key-errors/2.js
Outdated
|
|
||
| function square(3) { | ||
| return num * num; | ||
| } | ||
|
|
||
| // =============> write the error message here | ||
| Function square(3) |
There was a problem hiding this comment.
Can you review again the error message?
Sprint-2/1-key-errors/2.js
Outdated
Comment on lines
21
to
22
| function square(num) | ||
| return num*num |
There was a problem hiding this comment.
This code will look neater using proper syntax. E.g. space between num*num and ending the statement with ;
Also, the function is missing curly braces
Comment on lines
17
to
23
|
|
||
|
|
||
| const greating = "Hello there" | ||
| console.log (greating.toUpperCase()); | ||
|
|
||
| const heading = "lord of the rings" | ||
| console.log(heading.toUpperCase()); |
There was a problem hiding this comment.
Can you move this implementation into a function?
There was a problem hiding this comment.
Could you review this again?
The idea here is to write tests for various input data and edge cases, as well as to fix any bugs you find.
The test cases are missing.
Sprint-2/1-key-errors/0.js
Outdated
There was a problem hiding this comment.
Most of the files are missing Predictions, where it's required for you to write your prediction first.
kodnificent
added
Reviewed
HilolaRustam
added
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.