West Midlands | MAY | EMIN AKTURK | Sprint 3 | MODULE-STRUCTURING-AND-TESTING-DATA

[eminakturk]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[jenny-alexander]

You have done a lot of work in this PR! Good job.

In order for me to set the status to complete, there are a few fixes to make (please see comments left throughout the PR).

In addition to the comments that I left:

• I noticed that a number of tests are failing. It's really important to run the tests yourself and make sure they pass before you submit your PR for review. When you submit a PR with failing tests, it means that your code implementation is 'broken'.

• The files within Sprint-1 are set to be deleted. This will delete the files in the main repository (and for everyone 😱). I think you did this because you made changes to the file by mistake, is that correct? Since it was a mistake, can you revert these changes instead of deleting the files?
  One way to do this is to revert each file to the commit SHA before your deletion commit SHA. Let me know if you can figure out how to do this or if you would like some additional explanation.

[jenny-alexander]

I think you may be missing a few edge cases in your getAngleType function.

• What if we don't pass an angle value? const nothing = getAngleType();
• What if we pass a value that isn't a valid angle value? const tooBig = getAngleType(361);

[jenny-alexander]

If you run this file to see if your tests pass, what happens? I get an error related to the assertEquals function. Can you find the error and fix it?

fyi: You can test the file by opening your terminal (making sure you are in the Sprint-3/1-key-implement directory) and typing:
node 2-is-proper-fraction.js

[jenny-alexander]

There may be a few edge cases missed here.

• I expected the "Invalid card rank." assertion to be true for: const oddValue = getCardValue("345");
• I expected the "Invalid card rank." assertion to be true for: const onlySuit = getCardValue("♠");
• I expected the "Invalid card rank." assertion to be true for: const oneHundred = getCardValue("100♠");

[jenny-alexander]

I think you may be missing a few edge cases in your getAngleType function.

• What if we don't pass an angle value? const nothing = getAngleType();
• What if we pass a value that isn't a valid angle value? const tooBig = getAngleType(361);

[jenny-alexander]

Did you run the tests in this file? I get an error when I do, can you find it and fix it?

[jenny-alexander]

Can you review the test at line 25? The assertion fails.

[jenny-alexander]

I suggest adding tests for these edge cases:

• card value: 345
• card value: ♠
• card value: 100♠

[jenny-alexander]

Here are a few ideas to test edge cases.

• Is your countChar function count characters even if the case (i.e. lowercase or uppercase) is different? Can you add a test to check this?
• Does your countChar function count spaces as a character? Can you add a test to check this?

[jenny-alexander]

It looks like you didn't finish adding your tests to this file.
["th", "st", "nd", "rd"];

"th" is tested, but what about "st", "nd" and "rd"?

[jenny-alexander]

I only see the CYF provided test assertion in repeat.test.js file. Can you add more assertions for your repeat function?

[jenny-alexander]

@eminakturk - I noticed that your checklist is not quite right.
You have this: [x ]
😃 Instead, do this: [x]
(notice how I don't have a space around the x?)
It will format it to a checked off item.

[eminakturk]

Hello Jenny, Thank you for your great insights. I have completed fixing all the errors you pointed out. I hope and believe I did an okay job. Please let me know In case if I need to change anything else 😄

[jenny-alexander]

Great job implementing the suggested changes. 🙌

I have a few more comments:

1. The implementation you made in 1-get-angle-types.js (lines 11-17) is good. However, we could simplify this even more.
   If none of the criteria are met from lines 19-25, then the angle is considered invalid.

So after line 25, we could add a return statement like:
return "Invalid angle: Please provide a valid number";

---

2. The files you deleted from sprint 1 directory should be reverted. We don't want to delete repo files.

[eminakturk]

I have uploaded a fix for that and sent you a message from slack, thank you :)

[jenny-alexander]

In this case, if you push a PR with files that are deleted, it will delete the branches from the main repository.
It's better to revert this deletion completely -> and also good practice for you once you start working at a company and this same thing happens.

Can you research how to revert changes in a PR? Specifically "how to revert accidental deletion of files"?

[LonMcGregor]

Hi Emin, you still need to make the changes to revert the files mentioned above

[github-actions]

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

[eminakturk]

Hello, I just sorted the files back again.

[github-actions]

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

[jenny-alexander]

Approved!

[github-actions]

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

[github-actions]

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

[github-actions]

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.