CYF NORTH WEST| HABEN SOLOMON KIDANE| Module User Focused Data| Form controls| week 2 #298
Conversation
Feature/wireframe
Cakes-co Commit
✅ Deploy Preview for cyf-ufd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I am looking for your constructive feedbacks |
Habenk-coder
changed the title
|
cjyuan
added
Reviewed
There was a problem hiding this comment.
Thanks for this @Habenk-coder . There are a few things going on in here for you to look at.
First, please back out your other changes and just open a PR with the changes related to form controls. Next, please review the acceptance criteria and check your submission meets them. It's helpful to write them out one by one as comments in your file to help you check this.
Make sure to run Lighthouse and follow the advice it gives you to make your changes. Good luck! Come to class to get help if you are stuck.
| voluptatem accusantium, necessitatibus cum accusamus, id cumque harum | ||
| voluptates ipsum nisi vero illo dolore! Doloribus, quae hic. Facilis | ||
| voluptate nobis eum. | ||
| we believe that every celebration deserves a cake that is as unique and special as the occasion itself. |
There was a problem hiding this comment.
It looks like there are files in this PR that don't belong to this project. Can you open a PR with just the changes for Form Controls, please? Come to class to get help with this if you are stuck.
| <h2>T-shirt Order Form</h2> | ||
| <form name="tshirtForm"> | ||
| <label for="name">Customer's Name:</label> | ||
| <input type="text" id="name" name="name" required minlength="2" pattern="[A-Za-z]+"> |
There was a problem hiding this comment.
What would happen if my name was O'Donnell?
https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/
|
|
||
| <label for="email">Customer's Email:</label> | ||
| <input type="email" id="email" name="email" required> | ||
| <div class="error-message">Please enter a valid email address.</div> |
There was a problem hiding this comment.
What will happen with these error messages? Can you talk through what you expect?
| </div> | ||
|
|
||
| <script> | ||
| document.addEventListener("DOMContentLoaded", function() { |
There was a problem hiding this comment.
Does this meet the criteria listed in the readme? Can you explain how it does, or what your goal in with including this?
| text-decoration: none; | ||
| } | ||
|
|
||
| footer a:hover { |
There was a problem hiding this comment.
What would happen if I wasn't using a mouse?
SallyMcGrath
added
the
👀 Review Requirements
CYF NORTH WEST | HABEN SOLOMON KIDANE | Module User Focused Data| Form Controls | WEEK2
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Needs Review