London | Saeid Heidari | Module-User-Focused-Data | Week 2 | Form Controls #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-ufd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RihannaP
reviewed
Oct 30, 2024
| color: var(--text-100); | ||
| } | ||
|
|
||
| input:focus, select:focus { |
There was a problem hiding this comment.
Could you check your focus that it's working or not?
There was a problem hiding this comment.
I tested this, I expected when I clicked the form area it lit up the input area and it worked.
What did you expect instead?
There was a problem hiding this comment.
@persianquant Have you tried finding out which HTML elements can receive focus? Maybe you missed some elements?
|
I think except one missed focusable element, the form meets all the acceptance criteria. Good job. In any case, you can mark this as "Completed". |
cjyuan
added
Reviewed
persianquant
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.