-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LONDON | SHIRIN PANAHIAN | feature/wireframe | WEEK1 #300
LONDON | SHIRIN PANAHIAN | feature/wireframe | WEEK1 #300
Conversation
✅ Deploy Preview for cyf-ufd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @shirinpanahian , I can see a good work here! Observation: When submitting a PR, briefly explain your PR, so the reviewer can have a general view of what you've done. |
<p>Copyright © 2024 Code Your Future. All Rights Reserved.</p> | ||
<span class="footer-email">Email:<a href="mailto:[email protected]" >[email protected]</a></span> | ||
</footer> | ||
</body> | ||
</html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to close de tag here: </html>
<a href="#" class="read-btn">Read More</a> | ||
</section> | ||
</main> | ||
</div> | ||
<!-- Add your HTML markup here --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments that you no longer need, you may remove it. It will make the code more clean.
</section> | ||
|
||
<section class="column"> | ||
<img src="image/img2.png" alt="git-developer"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: when adding pictures, putting a good name on it, makes the code cleaner . Another suggestion is to use "alt" to describe the picture, like this: <img src="image/img2.png" alt="Git Developer">
} | ||
|
||
.container section:first-child{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could erase this blank line.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.