Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW | RAHWA ZESLUS | Module-User-Focused-Data| FEATURE/|WIREFRAME WEEK 1 #308

Closed

Conversation

RahwaZeslusHaile
Copy link

@RahwaZeslusHaile RahwaZeslusHaile commented Nov 2, 2024

NW | RAHWA ZESLUS | Module-User-Focused-Data feature/ wireframe|WEEK 1

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

I add the image as I was reviewed ,,
Ask any questions you have for your reviewer.
can you review this please?

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for cyf-ufd ready!

Name Link
🔨 Latest commit 0fb652c
🔍 Latest deploy log https://app.netlify.com/sites/cyf-ufd/deploys/67351cee563419000892a042
😎 Deploy Preview https://deploy-preview-308--cyf-ufd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RahwaZeslusHaile
Copy link
Author

PLEASE CAN YOU REVIEW MY WORK ?

@RahwaZeslusHaile RahwaZeslusHaile added the Needs Review Participant to add when requesting review label Nov 2, 2024
@RahwaZeslusHaile RahwaZeslusHaile changed the title The updated wireframe project NW | RAHWA ZESLUS | Module-User-Focused-Data| FEATURE/|WIREFRAME WEEK 1 Nov 2, 2024
@cjyuan
Copy link

cjyuan commented Nov 3, 2024

It seems that in the current repo you have a Module-User-Focused-Data folder which is also a Git repo. I think that's why your repo cannot be deployed to Netlify automatically. Can you fix that?

@cjyuan cjyuan added the 👀 Review Git Changes requested to do with Git label Nov 3, 2024
@RahwaZeslusHaile
Copy link
Author

Thanks for the review . I have removed the folder

@cjyuan
Copy link

cjyuan commented Nov 4, 2024

  • The boxes with a cross in the wireframe represents images. Can you add images to the page to make it more like the wireframe?
  • In general, when given a wireframe, we should pay attention to
    • Text alignments and justifications
    • Relative size and position of the elements.
      and make the page look like the wireframe as much as possible.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed 👀 Review Git Changes requested to do with Git Needs Review Participant to add when requesting review labels Nov 4, 2024
@RahwaZeslusHaile
Copy link
Author

Thank you in advance for taking your time ,I have tried to correct those reviews . Can you review my latest work please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants