Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYF-London | seerat junaid | Module-User-Focused-Data | Week 2 #319

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

seeratjunaid
Copy link

@seeratjunaid seeratjunaid commented Nov 10, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for cyf-ufd ready!

Name Link
🔨 Latest commit 02db81a
🔍 Latest deploy log https://app.netlify.com/sites/cyf-ufd/deploys/67333068b9110f0008c71926
😎 Deploy Preview https://deploy-preview-319--cyf-ufd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seeratjunaid seeratjunaid changed the title Form control work CYF-London | seerat junaid | Module-User-Focused-Data | Week 2 Nov 10, 2024
@seeratjunaid seeratjunaid added the Needs Review Participant to add when requesting review label Nov 12, 2024
@cjyuan
Copy link

cjyuan commented Nov 12, 2024

Form looks great.

May I suggest using a HTML validator (https://validator.w3.org/) to check for potential syntax errors in your HTML code?

Also, any reason to accept two or more spaces as a valid name?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Nov 12, 2024
@seeratjunaid
Copy link
Author

Thank you for taking the time to review my form. Your suggestion to use the HTML Validator was invaluable, especially since it was new to me. The tool made it easy to identify and correct my mistakes.

Additionally, I was experimenting with some new features, which led to unintentionally allowing multiple spaces in the name field. I have now addressed this issue and ensured that only single spaces are accepted.

Thanks again for your helpful feedback!

latest commit here

@seeratjunaid seeratjunaid added the Needs Review Participant to add when requesting review label Nov 12, 2024
@cjyuan
Copy link

cjyuan commented Nov 12, 2024

If you think you have made all the suggested changes, you can mark your work as completed.

@seeratjunaid seeratjunaid added Complete Participant to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants