Manchester | Bestun-Mohammedi | Module-User-Focused-Data | Week1 | form-controls #328
Conversation
✅ Deploy Preview for cyf-ufd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bestunmoh
changed the title
There was a problem hiding this comment.
Just one criteria missed, I think, again @bestunmoh . Tiny fix - take a look! Thanks for your hard work here.
Please open your PRs so you can get code review. This is the main arena for teaching on the course so don't miss out on this resource.
|
|
||
| <!-- Delivery Date --> | ||
| <label for="delivery-date">Delivery Date (within 4 weeks):</label> | ||
| <input type="date" id="delivery-date" name="delivery-date" required> |
There was a problem hiding this comment.
What validations could you add to meet the acceptance criteria? Validations added as an attribute to limit the range of this date picker?
There was a problem hiding this comment.
Hi . i added some new attribute.
There was a problem hiding this comment.
Hi @bestunmoh I can't see an update here. Have you pushed your changes to your branch on GitHub?
|
|
||
| <!-- Delivery Date --> | ||
| <label for="delivery-date">Delivery Date (within 4 weeks):</label> | ||
| <input type="date" id="delivery-date" name="delivery-date" required> |
There was a problem hiding this comment.
Hi . i added some new attribute.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.