Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYF_Glasgow | Mansoor Munawar | Module-User-Focussed-Data | Week 1 - Form controls #329

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MansoorM11
Copy link

No description provided.

Copy link

netlify bot commented Dec 7, 2024

Deploy Preview for cyf-ufd ready!

Name Link
🔨 Latest commit 79e5d2f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-ufd/deploys/6753a0c12c01e500088ec8c0
😎 Deploy Preview https://deploy-preview-329--cyf-ufd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MansoorM11 MansoorM11 added the Needs Review Participant to add when requesting review label Dec 7, 2024
@cjyuan cjyuan self-requested a review December 7, 2024 15:25
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all focusable elements inside the form have distinguishable appearance when focused.

Could also try using grid layout to layout form.

All other acceptance criteria have met.

Please choose an option
</option>
<option value="black">Black</option>
<option value="Green">Green</option>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you change to make the color value consistent?

margin-bottom: 10px;
}

form input:focus {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<button> and <select> can also have focus.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants