CYF Glasgow Dalila Boumezrag | Module-User-Focused-Data | week 2 #332
Conversation
✅ Deploy Preview for cyf-ufd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Hi @DalilaBou,
Excellent work here with the form
There was a problem hiding this comment.
Hi @DalilaBou ,
I think it is better to use px for elements with fixed sizes (e.g border, and box-shadow). Hence, I will recommend using rem instead of px.
There was a problem hiding this comment.
Hi @DalilaBou ,
Brilliant work here. However, I have left a few comments for you to address. Happy to approve once this is addressed.
Thanks
There was a problem hiding this comment.
Hi @DalilaBou ,
See previous comment about using rem instead of px
There was a problem hiding this comment.
HI @mrvicthor thanks for your feedback i will go through it
There was a problem hiding this comment.
Hi @DalilaBou ,
I just observed that the alt attribute in the img element is empty. Was this intentional?
There was a problem hiding this comment.
HI @mrvicthor thanks for your feedback i will go through it
mrvicthor
added
Reviewed
No description provided.