Skip to content

ITP: Update step submission instructions #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SpectacularLandscape
Copy link
Contributor

Closes #1422

What does this change?

  • Updates ITP module success pages to ask learners to create an issue on their Coursework Planner with links, then submit the issue to the CYF Course Portal
    • "objectives" front matter is updated to better fit the submission instructions
  • Adds a > [!NOTE] to each ITP module success page to explain a "completed" PR
  • Spring cleans ITP module success pages for consistency in "title" and "description" front matter

Checklist

Who needs to know about this?

@ZacheeNiyokwizera (task collaborator)
@CodeYourFuture/itp-syllabus-team (ITP content change review)
@SallyMcGrath (to continue discussion from #1425)
@kfklein15 (for updates to dashboard "acceptance criteria")

Copy link

netlify bot commented Apr 29, 2025

👷 Deploy request for cyf-curriculum pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5dddb35

Copy link

netlify bot commented Apr 29, 2025

👷 Deploy request for cyf-piscine pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5dddb35

Copy link

netlify bot commented Apr 29, 2025

👷 Deploy request for cyf-itd pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5dddb35

Copy link

netlify bot commented Apr 29, 2025

👷 Deploy request for cyf-common pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5dddb35

Copy link

netlify bot commented Apr 29, 2025

👷 Deploy request for cyf-tracks pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5dddb35

Copy link

netlify bot commented Apr 29, 2025

👷 Deploy request for cyf-sdc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5dddb35

Copy link

netlify bot commented Apr 29, 2025

👷 Deploy request for cyf-launch pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5dddb35

## ✅ To complete _this_ module, you must:

Submit the following items to complete this module on the [Course Platform](https://application-process.codeyourfuture.io/):
1. Make a new issue on your own Coursework Planner.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add specific guidance on how to name this issue, like we do for naming pull requests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the point of the issue is to have a link to share, this doesn't feel super important, but nudging people towards consistency and following instructions is always a good idea? So probably yes?


> [!NOTE]
> A pull request is _completed_ when a volunteer has added the "Complete" tag. If no one is reviewing your PRs, please ask on Slack in #cyf-code-review.

Copy link
Contributor Author

@SpectacularLandscape SpectacularLandscape Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a good place for a > [!CAUTION] to explain that failing to enroll as a trainee means the course can't be completed.

I just couldn't get the wording. It sounded like either:

  1. You can't get a head start on work in the next module until fully enrolled
  2. Enrolling as a trainee is the only true requirement to complete ITP

Example bad wording:

  • "You must enroll as a trainee to continue studying Intro To Programming."
  • "Enrolling as a trainee is required to complete Intro To Programming."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a CAUTION on the Onboarding rather than Data Flows module?

But I think adding a warning there would make a lot of sense. Our policy is: If you haven't enrolled as a trainee by week 6, you will be removed from the ITP cohort.

So let's add a big caution to Onboarding's success page? Something like:

> [!CAUTION]
>
> You must enrol as a trainee. If you do not enrol as a trainee by the end of week 6, you will be removed from the ITP cohort.
>
> If you are removed from the cohort, you will be allowed to keep attending class. You can apply to start again in the next cohort if you want.

- A link to your _completed_ pull request for "[Sprint 2 Coursework](https://github.com/CodeYourFuture/Module-Data-Groups/issues/14)".
- A link to your _completed_ pull request for "[Quote Generator App](https://github.com/CodeYourFuture/Module-Data-Groups/issues/20)".
- A link to your "[Brag Diary](https://github.com/CodeYourFuture/Module-Data-Groups/issues/10)".
- An explanation of how you have used your "[Brag Diary](https://github.com/CodeYourFuture/Module-Data-Groups/issues/10)" to record your progress.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a carry over from the old front matter ("explain how you have used it to record your progress"), but remains vague.

There's also a note on the Brag Diary Issue that says it's fine not to share as it's a personal document, which could be confusing when we ask for it to be submitted.

1. On the issue, add:
- Evidence you have completed "[Intro to Python](https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/issues/21)".
- A link to your _completed_ pull request for "[Sprint 3 Coursework Exercises](https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/issues/6)".
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen most trainees submitting 3 pull request links on previous iterations of ITP.

Are we asking for just one PR (for sprint 3 exercises), or 3 PRs to cover all sprints? The linked issue suggests we want just one PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ask for 3 PRs, one per sprint. We can link to all three issues, if that would be more clear, or just not link to the issue if that would be more clear too?

+++

> 🎯 Complete onboarding and [apply to enroll as a Trainee](https://forms.gle/vRuofa7aeL5DsbhGA)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing this change out, as removing the note from the top of the page (where it gets noticed early) could be controversial.

To me it's a duplicate of steps below, and is vague on what it means to complete onboarding.

Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 5dddb35
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6811300a9fb8810008773b3c
😎 Deploy Preview https://deploy-preview-1426--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks so much!

(Also for the future, PRs made from the CodeYourFuture repo get deploy previews by default, whereas ones from forks need manually allowing each time :))

## ✅ To complete _this_ module, you must:

Submit the following items to complete this module on the [Course Platform](https://application-process.codeyourfuture.io/):
1. Make a new issue on your own Coursework Planner.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the point of the issue is to have a link to share, this doesn't feel super important, but nudging people towards consistency and following instructions is always a good idea? So probably yes?


> [!NOTE]
> A pull request is _completed_ when a volunteer has added the "Complete" tag. If no one is reviewing your PRs, please ask on Slack in #cyf-code-review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a CAUTION on the Onboarding rather than Data Flows module?

But I think adding a warning there would make a lot of sense. Our policy is: If you haven't enrolled as a trainee by week 6, you will be removed from the ITP cohort.

So let's add a big caution to Onboarding's success page? Something like:

> [!CAUTION]
>
> You must enrol as a trainee. If you do not enrol as a trainee by the end of week 6, you will be removed from the ITP cohort.
>
> If you are removed from the cohort, you will be allowed to keep attending class. You can apply to start again in the next cohort if you want.

1. On the issue, add:
- Evidence you have completed "[Intro to Python](https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/issues/21)".
- A link to your _completed_ pull request for "[Sprint 3 Coursework Exercises](https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/issues/6)".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ask for 3 PRs, one per sprint. We can link to all three issues, if that would be more clear, or just not link to the issue if that would be more clear too?

- A link to your _completed_ pull request for "[Alarm Clock App](https://github.com/CodeYourFuture/Module-Data-Groups/issues/26)".
- A link to your _completed_ pull request for "[Sprint 2 Coursework](https://github.com/CodeYourFuture/Module-Data-Groups/issues/14)".
- A link to your _completed_ pull request for "[Quote Generator App](https://github.com/CodeYourFuture/Module-Data-Groups/issues/20)".
- A link to your "[Brag Diary](https://github.com/CodeYourFuture/Module-Data-Groups/issues/10)".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- A link to your "[Brag Diary](https://github.com/CodeYourFuture/Module-Data-Groups/issues/10)".
- A link to your "[Brag Diary](https://github.com/CodeYourFuture/Module-Data-Groups/issues/10)". (It's ok if this is a private document, you don't need to share it if you don't want to, but please include the link for your own reference).

Comment on lines +39 to +40
> [!NOTE]
> A pull request is _completed_ when a volunteer has added the "Complete" tag. If no one is reviewing your PRs, please ask on Slack in #cyf-code-review.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throughout all modules, this note can mention one week as a guideline for how long a PR can go 'unreviewed' by a volunteer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

ITP: Update step submission instructions for all modules to tell people to link to issues
2 participants