Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The last edition #49

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
21e80e2
upgrade to react 18 + sass
SallyMcGrath Jan 30, 2023
db71448
strip unwanted files, add missing test files
SallyMcGrath Jan 30, 2023
156a8b4
add .env example
SallyMcGrath Jan 30, 2023
97ff92a
swap npm for yarn
SallyMcGrath Jan 30, 2023
83668e2
stub a simple sass theme
SallyMcGrath Jan 30, 2023
a4a205d
stub example components
SallyMcGrath Jan 30, 2023
1eb1a44
tweak head, ready for dev
SallyMcGrath Jan 30, 2023
b06a700
mistakenly renamed App.js
SallyMcGrath Jan 30, 2023
c44a720
strip unwanted files, add missing test files
SallyMcGrath Jan 30, 2023
05ad094
create PR template
SallyMcGrath Jan 30, 2023
684296b
Merge pull request #1 from CodeYourFuture/upgrade-for-hackathon
SallyMcGrath Jan 30, 2023
a703fea
Update issue templates
SallyMcGrath Jan 30, 2023
fca9249
rm git add, format code
SallyMcGrath Feb 3, 2023
9ce3280
Merge remote-tracking branch 'origin/master'
SallyMcGrath Feb 3, 2023
6ef5b18
link to google fonts cdn
SallyMcGrath Feb 4, 2023
468bb68
assign Raleway to font variable
SallyMcGrath Feb 4, 2023
4f64c2f
rename font variable to theme-font
SallyMcGrath Feb 4, 2023
87d25de
Merge pull request #3 from CodeYourFuture/feature/type
Emeka1993 Feb 4, 2023
f85833a
spacing sizes
SallyMcGrath Feb 4, 2023
f0709d8
Create Main.js
zkhing Feb 4, 2023
0c70408
add JSON file with sample data
LucyMac Feb 4, 2023
d43bda8
Merge pull request #20 from CodeYourFuture/sample-json-data-14
LucyMac Feb 4, 2023
20834d1
Header Done
Emeka1993 Feb 4, 2023
26040ad
moving Zaw's comments to app.js
SallyMcGrath Feb 4, 2023
0718549
deleting main component as we think we don't need this complexity
SallyMcGrath Feb 4, 2023
ac7ffc6
Updated Header
Emeka1993 Feb 4, 2023
898d462
adding img
Nikolov87 Feb 4, 2023
c3d2c75
Merge pull request #13 from CodeYourFuture/feature/spacing
zkhing Feb 4, 2023
80162d0
Header
Emeka1993 Feb 4, 2023
906cd43
Deleted package lock json
Emeka1993 Feb 4, 2023
0024a0c
Delete yarn.lock
SallyMcGrath Feb 4, 2023
e6d62df
Merge pull request #21 from Emeka1993/feature/header
SallyMcGrath Feb 4, 2023
33a51da
re-add yarn lock
SallyMcGrath Feb 4, 2023
a27a41e
Merge pull request #26 from CodeYourFuture/replace-yarn-lock
youweb3 Feb 4, 2023
eecdaf8
adding icon fiel
Nikolov87 Feb 4, 2023
2ba732b
Update yarn.lock
Nikolov87 Feb 4, 2023
ab60c21
Merge pull request #27 from CodeYourFuture/eature/images
Nikolov87 Feb 6, 2023
cc6cf5e
Merge branch 'main'
LucyMac Mar 2, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.example
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# REACT_APP_SITE_TITLE="CYF Weather App"
38 changes: 38 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

**Additional context**
Add any other context about the problem here.
25 changes: 25 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: Feature request
about: Specify a feature for this project
title: ''
labels: ''
assignees: ''

---

**User story**
As a __ I want __ in order to __

**Specification**
A clear and concise description of what you want to happen, eg

Given a search component
When I type a location
And I select "search"
Then the weather in that location is shown

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.
22 changes: 22 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
## Contributors, PR Template

Self checklist

- [ ] I have committed my files one by one, on purpose, and for a reason
- [ ] I have titled my PR with ISSUE NUMBER | ISSUE TITLE
- [ ] I have linked my PR to the paired issue with #123
- [ ] I have tested my changes
- [ ] My changes follow the [style guide](https://syllabus.codeyourfuture.io/guides/code-style-guide/)
- [ ] My changes meet the acceptance criteria

## Changelist

Briefly explain your PR.

## Context

Link to ticket with `fixes #123`

## Questions

Ask any questions you have for your reviewer.
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Please **fork** and **clone** this repository. There are instructions for how t
Then navigate to the correct directory using the command line.

Once you're in the project directory, you can run:
```
```bash
npm install

npm start
Expand All @@ -21,8 +21,8 @@ Open [http://localhost:3000](http://localhost:3000) to view it in the browser.
Edit `App.js` and add a tiny change, like adding your name, to see if the change appears.

Add and commit this change to git, and push it up to your remote github repo:
```
git add .
```git
git add App.js
git commit -m "Added my name to the app"
git push
```
Expand Down Expand Up @@ -60,12 +60,12 @@ There is a special way to show images from a React app created with create-react

At the top of your component, import the image like this (remember to give it a name!)

```
```javascript
import storm from '../img/weather-icons/storm.svg';
```

Then later in your `<img/>` tag, use the imported value as the image source, like this:
```
```html
<img src={storm} alt="storm icon" />
```

Expand Down Expand Up @@ -100,7 +100,7 @@ Copy all contents into a new file and add it to your project somewhere under the

Import it into your react app with

```
```javascript
import FakeWeatherData from "./data/FakeWeather.json";
```

Expand All @@ -115,7 +115,7 @@ This JSON represents weather data for **just one city**.
It includes **an array called `list` containing the weather predicitons for the next 5 days, split into 8 x 3-hour chunks**
Each object inside `list` contains a `weather` array with an object that looks like this:

```
```json
"weather": [
{
"id": 521,
Expand Down Expand Up @@ -169,7 +169,7 @@ Look at the design:

- Each object inside `list` contains a `weather` array with an object that looks like this:

```
```json
"weather": [
{
"id": 521,
Expand Down
Loading