Add file weight option #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnlk
reviewed
Apr 13, 2024
src/github.sh
Outdated
| @@ -5,14 +5,16 @@ GITHUB_API_HEADER="Accept: application/vnd.github.v3+json" | |||
| github::calculate_total_modifications() { | |||
| local -r pr_number="${1}" | |||
| local -r files_to_ignore="${2}" | |||
| local -r changed_file_weight="${3:-0}" | |||
There was a problem hiding this comment.
existing pattern seems to be to set the default values in the actions.yml file rather than inline here
|
|
||
| echo $((additions + deletions)) | ||
| echo $((additions + deletions + (changed_files * changed_file_weight))) |
There was a problem hiding this comment.
To use an example, if there's a 10 file change and the changed_file_weight is set to 10, then we're adding an additional 100 lines to the calculated diff? Is that the intention?
If you're trying to calculate the complexity of the change, that might require understanding the number of line changes per total lines in all files. For example, a 100 line file having 30 lines changes would be complexity 30.
There was a problem hiding this comment.
Also, this change missing the else block here when files_to_ignore is set.
HerrDerb
force-pushed
the
include-file-weight
branch
from
ccca251 to
a2b9cdb
Compare
|
Close as outdated and not significant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #69