Familiada #1

MarcinGladkowski · 2019-03-10T17:33:22Z

Proszę o rezencję :)

firemark · 2019-03-10T17:34:27Z

Widzę że wziąłeś sobie do serca dużą ilość commitów :D

firemark · 2019-03-10T17:44:56Z

public/index.html

@@ -12,7 +12,7 @@
 <div class="container">
    <div class="row">
        <div class="col-lg-2 text-center blue-team team">
-            <h4 class="name">NIEBIESCY</h4>
+            <h4 class="name">Phpowcy</h4>


i think, in this place should be Pythonowcy

firemark · 2019-03-10T17:51:20Z

src/scripts/board.js

+    const rowFields = document.querySelectorAll(`[data-answer-num]`);
+    for (let i = 1; i <= 6; i++) { 
+        if (i > answerLength && rowFields.item(i - 1) !== null) {
+            rowFields.item(i - 1).style.display = 'none';


duplicated code - in this place you should save display type (in ex. let display var) and execute after if execution like:

let display; if (…) {} else {} rowFields.item(i - 1).style.display = display;

Now you can move display code to another function or add another condition more safety

firemark · 2019-03-10T17:53:42Z

src/scripts/board.js

+ */
+function recordButton(status) {
+    const button = document.querySelector('#recordButton');
+    (status === 'start') ? button.className = 'rec' : button.className = 'notRec'; 


ugly!
ternary conditional operator would be only for returns value, not to modify.
would be:

button.className = (…) ? A : B;

firemark · 2019-03-10T17:54:28Z

src/scripts/main.js

@@ -15,11 +19,13 @@ board.setPoints(TEAMS.RED, 0);
 board.setErrors(TEAMS.RED, 0);
 board.setErrors(TEAMS.BLUE, 0);

-board.setQuestion('Coding Dojo Silesia');
+const game = new Game([new Team(TEAMS.BLUE), new Team(TEAMS.RED)], new QuestionStore(questions));


arguments are too long - please move arguments to another vars and use them in constructor (is more readable)

firemark · 2019-03-10T17:55:54Z

src/scripts/main.js


-speech.loadGrammar(['żółty', 'zielony', 'fioletowy', 'niebieski']);
+speech.loadGrammar(game.getRound().getQuestion().getAnswersWords());


this line breaks law of demeter - https://en.wikipedia.org/wiki/Law_of_Demeter
please make method game.getAnswersWords()

firemark · 2019-03-10T18:08:40Z

src/scripts/model/question.js

+export default class Question {
+    constructor(name, answers) {
+        this.name = name;
+        this.answers = answers.filter(answer => answer);


why answers array has a empty values?

firemark · 2019-03-10T18:09:29Z

src/scripts/model/questionStore.js

+    }
+
+    getRandomQuestionId() {
+        return Math.floor(Math.random() * (this.questions.length - 1 + 1) + 1) - 1;


- 1 + 1? :)

firemark · 2019-03-10T18:11:08Z

src/scripts/model/round.js

+        this.status = ROUND_STATUS.DEFAULT;
+        this.points = 0;
+        this.question = question;
+        board.setQuestion(this.question.getName());


this breaks MVC rule - Round object shouldn't set question in view.
The best option is use a another class (like RoundView?) to draw this

firemark · 2019-03-10T18:11:41Z

src/scripts/model/team.js

+        this.points += points;
+    }
+
+    addError() {


maybe incError would be better?

firemark · 2019-03-10T18:13:30Z

test/board.test.js

+
+        board.manageAnswerFields(1);
+
+        expect(document.querySelector('[data-answer-num="1"]') !== undefined)


not.toBe(undefined) would be better

inirudebwoy · 2019-03-10T18:26:02Z

Sorry but can't find jQuery

MarcinGladkowski added 30 commits February 28, 2019 23:30

fix style for fails question

d9bb9eb

remove bad data

d01f9d6

import questions

ed91b46

create answer model

241b228

create question model

4361c41

create qestionStore to contain all questions

bcf21ce

add simple questionStore test

e8daf17

working on parsed question object

03ee063

reactor questionStore tests

aefcc69

change to export default

2d0e40c

create game model

8001414

return parse random question

c88a89d

create Round model

86860e5

create Team model

c8105ad

create test for model Game

2a6586a

refactor test questionStore

4072061

method to hide unused board rows

d2ead9a

simple recognize user answer

089c78f

add getters to game model

d03864d

add getters to question model

ae5f34f

method to disable unused board rows on round

73797fe

method to add points and errors

bbeb6dd

test how choose good player answer answer

70af8e6

test commit

5da41ea

check if row exists

a75f6e6

refactor test , set always the same question

7a6383c

add getters

8aeb64e

add methods to points, status and getters

a37586e

fix when get random question index

17bdd41

simple parsed user answers

ddd5ec3

MarcinGladkowski added 25 commits March 5, 2019 23:54

use methods to manage fields and team

e2a9a00

refactor tests for game

6728e61

refactor tests for game

c7df2b4

rename tests methods

80b055d

add testing document

d471007

add styles for record button

99e90ef

create record button

100e73c

add method to set winner team, and display recording

1653f60

add test for finish game

90c347e

add statuses for round

3a8d7e9

add tests for difference strategy

66abccf

getter for points

3c3f9b4

run and stop record button

c39d5a0

move start new round to game model

7d26f0b

add getters and check status fo game

d3b108f

multiple points on round 4 and 5

ffdc889

initial round counter

d4cb689

build assets

98ed145

fix multiply points

36860d1

change names in template

2aa3f5d

add annotation

2eca74c

test 2 scenarios

335c8a1

method to reset team points

c724b9d

reset errors of teams

51cbb0d

display another fields when change new round

4f41232

MarcinGladkowski closed this Mar 10, 2019

MarcinGladkowski reopened this Mar 10, 2019

firemark requested changes Mar 10, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Familiada #1

Familiada #1

MarcinGladkowski commented Mar 10, 2019

firemark commented Mar 10, 2019

firemark Mar 10, 2019

firemark Mar 10, 2019

firemark Mar 10, 2019

firemark Mar 10, 2019

firemark Mar 10, 2019

firemark Mar 10, 2019

firemark Mar 10, 2019

firemark Mar 10, 2019

firemark Mar 10, 2019

firemark Mar 10, 2019

inirudebwoy commented Mar 10, 2019


		speech.loadGrammar(['żółty', 'zielony', 'fioletowy', 'niebieski']);
		speech.loadGrammar(game.getRound().getQuestion().getAnswersWords());


		board.manageAnswerFields(1);

		expect(document.querySelector('[data-answer-num="1"]') !== undefined)

Familiada #1

Are you sure you want to change the base?

Familiada #1

Conversation

MarcinGladkowski commented Mar 10, 2019

firemark commented Mar 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

inirudebwoy commented Mar 10, 2019