CY-1592: Use correct positive and negative amounts. (#64)

* CY-1592: Use correct positive and negative amounts. * CY-1592: Make sure tests pass. * CY-1592: Bump version
CoinifySoftware · Dec 12, 2024 · 38ca077 · 38ca077
1 parent 9706022
commit 38ca077
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/lib/ApiResponseConverter.js b/lib/ApiResponseConverter.js
@@ -163,9 +163,14 @@ function convertFromKrakenTrade(id, trade) {
     return [ error, null ];
   }
 
-  const baseAmount = coinifyCurrency.toSmallestSubunit(parseFloat(trade.vol), baseCurrency);
   const feeAmount = coinifyCurrency.toSmallestSubunit(parseFloat(trade.fee), quoteCurrency);
-  const quoteAmount = coinifyCurrency.toSmallestSubunit(parseFloat(trade.cost), quoteCurrency);
+  const roundBaseAmount = coinifyCurrency.toSmallestSubunit(parseFloat(trade.vol), baseCurrency);
+
+  //Ensure we use the correct side
+  const baseAmount = trade.type === 'buy' ? roundBaseAmount : -roundBaseAmount;
+  const roundedQuoteAmount = coinifyCurrency.toSmallestSubunit(parseFloat(trade.cost), quoteCurrency);
+  const quoteAmount = trade.type === 'buy' ? -roundedQuoteAmount : roundedQuoteAmount;
+
 
   return [ null, {
     externalId: id,

diff --git a/package.json b/package.json
@@ -43,5 +43,5 @@
     "test": "LOG_LEVEL=fatal mocha --config .mocharc.json",
     "test-watch": "LOG_LEVEL=info mocha --config .mocharc.json --watch"
   },
-  "version": "2.5.0"
+  "version": "2.5.1"
 }
diff --git a/test/unit/listTradeHistoryForPeriod.test.js b/test/unit/listTradeHistoryForPeriod.test.js
@@ -242,7 +242,9 @@ describe('#listTradeHistoryForPeriod', function () {
       expect(trades).containSubset([
         {
           baseCurrency: 'ETH',
-          quoteCurrency: 'USD'
+          quoteCurrency: 'USD',
+          baseAmount: 10000000000,
+          quoteAmount: -30010
         },
         {
           baseCurrency: 'EUR',
@@ -254,7 +256,9 @@ describe('#listTradeHistoryForPeriod', function () {
         },
         {
           baseCurrency: 'BTC',
-          quoteCurrency: 'USD'
+          quoteCurrency: 'USD',
+          baseAmount: -1000000,
+          quoteAmount: 30010
         },
         {
           baseCurrency: 'BTC',