Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Pennyway 색상표 Tailwind 적용 #6

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

BangDori
Copy link
Collaborator

@BangDori BangDori commented Oct 13, 2024

작업 이유

  • tailwind color config 적용
  • auto assignees & reviewers 설정
  • API Specification 작성
  • AWS Amplify 적용

작업 사항

1️⃣ auto assignees & reviewers 설정

매번 수동으로 Assignees와 Reviewers를 설정하는 것은 번거로운 작업이라고 생각하여 DX 향상을 위해 auto-assign-action를 적용하였습니다.

2️⃣ tailwind color config 적용

색상은 Pennyway 03. GUI에 적용된 색상 표를 참고하여 tailwind color config를 적용하였습니다. 색상명의 첫 글자만 따서 사용하는 것은 사용성은 편리할 지 몰라도 해당 색상이 가지는 의미를 명확히 알기 어렵다고 생각하여 색상명은 풀네임으로 추가하였습니다.


리뷰어가 중점적으로 확인해야 하는 부분

  • 색상이 figma와 일치하나요?
  • pennyway-client-webview-next의 wiki에 작성된 API Specification이 정상적으로 입력 되었나요?

발견한 이슈

1. 리뷰어가 1명만 등록되는 문제

auto-assign-action에서 리뷰어가 1명만 등록되는 문제가 있어 해당 이슈를 참고하여 해결하였습니다.

2. AWS Amplify 연동 에러

image

빌드가 정상적으로 이루어지지 않아서 깃허브에 표시 조차 되고 있지 않았습니다. 해당 문제 해결하기 위해서 amplify.yml 빌드 설정 파일에 다음 라인을 추가하였습니다.

version: 1
frontend:
  phases:
    preBuild:
      commands:
        - corepack enable # ✅ pnpm을 관리하는 corepack 활성화
        - corepack prepare pnpm@latest --activate # ✅ 최신 pnpm 설치 및 활성화
        - pnpm install --frozen-lockfile
    build:
      commands:
        - pnpm run build
  artifacts:
    baseDirectory: .next
    files:
      - '**/*'
  cache:
    paths:
      - .next/cache/**/*
      - node_modules/**/*

reviewers에 프론트 팀원 모두가 적용되지 않는 문제가 있어 reviewers를 명시하였습니다.
@BangDori BangDori closed this Oct 13, 2024
@BangDori BangDori reopened this Oct 13, 2024
@BangDori BangDori marked this pull request as draft October 13, 2024 15:00
@BangDori BangDori marked this pull request as ready for review October 13, 2024 15:01
@github-actions github-actions bot requested a review from suhwan2004 October 13, 2024 15:01
리뷰어의 수를 명시해주지 않으면 1명만 등록되는 문제가 있어 0으로 명시하였습니다.
@suhwan2004 suhwan2004 requested a review from Legitgoons October 13, 2024 15:05
@BangDori BangDori marked this pull request as draft October 13, 2024 15:06
@BangDori BangDori marked this pull request as ready for review October 13, 2024 15:06
Copy link
Collaborator

@suhwan2004 suhwan2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주말에도 불철주야 고생 많으십니다! 간단하게 질문 남겨두었습니다!

tailwind.config.ts Show resolved Hide resolved
Copy link
Member

@Legitgoons Legitgoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto assign 맛있네요 ㅋㅋ 병합하셔도 좋습니다!

@BangDori BangDori closed this Oct 14, 2024
@BangDori BangDori reopened this Oct 14, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-6.d1rrzjx2upcmxq.amplifyapp.com

Copy link
Collaborator

@suhwan2004 suhwan2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! .

@BangDori BangDori merged commit 3390d69 into main Oct 14, 2024
4 of 6 checks passed
@BangDori BangDori deleted the feat/tailwind-color-config branch October 14, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants