tiles: duplicated rendering #11134
Merged
tiles: duplicated rendering #11134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
changed the title
eszkadev
changed the title
eszkadev
requested review from
mmeeks and
caolanm
and removed request for
mmeeks
caolanm
reviewed
Feb 11, 2025
mmeeks
approved these changes
Feb 11, 2025
| if (!cachedTile || tooLarge) | ||
| { | ||
| forceKeyFrame = true; |
There was a problem hiding this comment.
Looks sensible to me =) I was worried about the race between the kit and coolwsd but we request this tile anyway I guess.
|
Looking good to me for an early merge on red - thanks Szymon =) ! |
eszkadev
force-pushed
the
private/eszkadev/tiles-duplicated
branch
from
39e70e8 to
cd88042
Compare
Just logging so we know if cache cleanup was done before. That will tell us if we might want to actively render something. If tile cache was empty, we can just now schedule a new render. It can be useful: - on initial load (nothing in cache yet) - on cache cleanup (we lost old tiles) Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I116f80dcba5d5fd70bb00dfa8823781cd0aa2596
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I99c43ee4fb79d422b336b625b7b1a2599837cbce
related to #10980 open calc and use page down to enter some initially not visible area notice in debug tools that tiles are rendered twice If any tile rendering is already pending - let's don't request it again. Use shared function for that check which was used only in one place but forgotten in hadnling the incoming tilecombine message. Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Icc1bf97826ec8b1cb1185b6f30dc2daf6d0355ea
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I7cbb8524db50cfc38d68d8c949d6637293226ce8
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Ie890924f7f8c307f18a79726ddc390bbf7c74965
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Ie908ee8369339ee4633bbc9251ac03ba460516e8
eszkadev
force-pushed
the
private/eszkadev/tiles-duplicated
branch
from
bd0d5fe to
cf26cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10980
Check if we have pending rendering before requesting new one for the same tile.
Add some useful logging for rare cases in TRC.
Client only "can" request rendering keyframe by wid=0 when tile is not in cache.
Client cannot force it when we already have correct one.
Manual test:
Check what we received, ideally would be to just get single tile as it wasn't edited.