Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose dialogService to extensionManager #2113

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Expose dialogService to extensionManager #2113

merged 3 commits into from
Dec 31, 2024

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Dec 31, 2024 •
edited
Loading

Ref: Comfy-Org/desktop#486

This PR:

  • Renames showPromptDialog to prompt to match window.prompt
  • Renames showConfirmDialog to confirm to match window.confirm
  • Exposes dialogService to extensionManager

@huchenlei huchenlei requested review from a team as code owners December 31, 2024 21:48
@huchenlei huchenlei merged commit 174a9a1 into main Dec 31, 2024
10 checks passed
@huchenlei huchenlei deleted the show_prompt_dialog branch December 31, 2024 22:01
@ltdrdata ltdrdata mentioned this pull request Jan 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@huchenlei