Custom node thumbnail variant #3682
Conversation
|
|
||
| return `${basePath}${indexSuffix}.${template.mediaSubtype}` | ||
| } | ||
|
|
||
| const thumbnailVariantRe = /.*\.(?<variant>[^\.]+)/ | ||
| const thumbnailVariantList = ['compareSlider', 'hoverDissolve', 'zoomHover'] |
There was a problem hiding this comment.
We would just need to udpate this list for new variants
lerignoux
force-pushed
the
custom_node_thumbnail_variant
branch
5 times, most recently
from
6681e4f to
6bf6a71
Compare
lerignoux
force-pushed
the
custom_node_thumbnail_variant
branch
from
6bf6a71 to
f0206af
Compare
lerignoux
force-pushed
the
custom_node_thumbnail_variant
branch
2 times, most recently
from
eb4489a to
01aa0f5
Compare
lerignoux
force-pushed
the
custom_node_thumbnail_variant
branch
3 times, most recently
from
da4ac03 to
852c539
Compare
| } | ||
| } | ||
| const wrapper = shallowMount(TemplateWorkflowCard, { propsData: data }) | ||
| // @ts-expect-error 'thumbnailVariant is computed' |
There was a problem hiding this comment.
I don't really understand why this is needed, the computed does exists. and the test works.
Any idea how to properly fix this ?
lerignoux
force-pushed
the
custom_node_thumbnail_variant
branch
from
852c539 to
fffc1c1
Compare
|
@christian-byrne Can you take a look? |
|
Yes, I can took a look today and tomorrow. I would really like this feature to be integrated as well, and appreciate the PR. I can also look at #3710 today. After looking at it briefly for the first time just now, my intial thoughts is that we might even be able to allow custom node to specify their own index.json in this format. But let me look at code more properly first. Also unrelated, but I can also help push through the model whitelisting feature today/tomrrow @lerignoux. Sorry for delay! |
Thanks a lot, no worries, I know there are 30 PR pending in parallel :D I can try to do the switch using an |
I wanted to use the thumbnail variant in a custom node I am doing but noticed it was not available.
So I wanted to propose a simple setup for this leveraging the workflow name extensions.
Cf #3684
If a custom node provides a thumbnail Variant at the end of the filename. For instance
workflow_1.compareSlider.jsonThen the front can toggle it's display for the relevant variant.
The title and description are then cleaned of the variant suffix.
It is a bit heavy on string computation, Do you think it is relevant to add caching/optimisations ?
If it is ok for integration I'll do a MR to update the documentation for this.
┆Issue is synchronized with this Notion page by Unito