[refactor] Refactor file handling #3955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
changed the title
christian-byrne
force-pushed
the
refactor/use-mime-type-constants
branch
from
5d8bd81 to
ff36273
Compare
christian-byrne
added a commit
that referenced
this pull request
May 30, 2025
Replace dynamic import with static import in handleFile method to eliminate race condition causing Playwright test flakiness. The dynamic import introduced asynchronous behavior that created timing issues in tests expecting immediate file processing completion. Fixes #3955 test flakiness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors file drop handling to use the supportedWorkflowFormats.ts constants as a source of truth. This makes extending file format support more maintainable by centralizing MIME types in a single location. Fixes #3651.
┆Issue is synchronized with this Notion page by Unito