-
Notifications
You must be signed in to change notification settings - Fork 273
[3d] initial version of 3d editor #3968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice overall. We could also consider adding it to the floating toolbox rather than litegraph context menu. See #3603.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Mostly nits / flagging for translation.
Everything apart from the g.apply
, g.cancel
can be merged as-is and be done as follow-ups.
#3968 (review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey so had a play around with this today; looks great in the editor. We just need to get the Vue controls using the normal controls, and using tailwind CSS.
Also need some tooltips on the three buttons on the left, so people know what they do.
More than happy to help out w/this when time permits. Could also just make a couple of small changes to show you what I mean, and leave the rest to you.
Also have some ideas for really easy future additions.
/> | ||
</div> | ||
|
||
<div class="w-64 bp-4 flex-none flex flex-col"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Initial version for 3d editor.
The Load3D node previously had an obvious flaw - as a node, it was limited by the node's own size, providing only limited operational space. As a reference, the Mask Editor provides a full-screen mode to facilitate more user operations. Similarly, I'm providing a 3D Editor as the 'full-screen mode' for the Load3D node. Currently, this is only a basic implementation that allows for minimal modifications. However, as a full-screen approach, it provides the potential for us to implement more features.
The demo is
2025-05-22.23-01-59.mp4
┆Issue is synchronized with this Notion page by Unito