Refactor app menu items #4665

pythongosssss · 2025-08-03T16:08:57Z

Restructures the application menu

rename Workflow to File
move new & template items to top level
add View menu and related sub items

Commands

add "active" state getter shown as checkmark in the menu

Node side panel

add refresh node defs
change reset view icon

Help center

change to use store for visibility

Fixes

Fix bug with mouse down where if you drag mouse out, mouse up wasn't caught
Fix issue with canvas info setting not triggering a redraw on change

┆Issue is synchronized with this Notion page by Unito

- rename Workflow to File - move new & template items to top level - add View menu and related sub items Commands - add "active" state getter shown as checkmark in the menu Node side panel - add refresh node defs - change reset view icon Help center - change to use store for visibility Fixes - Fix bug with mouse down where if you drag mouse out, mouse up wasn't caught - Fix issue with canvas info setting not triggering a redraw on change

JorgeR81 · 2025-08-04T23:05:24Z

In the View menu, I would:

Remove: Queue Panel, Node Library, Model Library, Workflows ( unless you're planning to have and option to hide the Sidebar, when it's minimized )
Remove: Manager ( since it's in the main menu already ) ( unless this is supposed to show the legacy Manager, instead )
Remove: Help Center ( since this could be added to the Help sub menu )
Add: Minimap, Toggle Link Visibility ( so that we can hide the graph canvas menu, but still have these options accessible )

I would also add a new icon for Toggle Link Visibility, since it's the same as Focus Mode.

…actor

…-Org/ComfyUI_frontend into pysssss/menu-item-refactor

…actor

- Remove queue, node lib, model lib, workflows, manager, help center - Add minimap, link visibility

…-Org/ComfyUI_frontend into pysssss/menu-item-refactor

…actor

…-Org/ComfyUI_frontend into pysssss/menu-item-refactor

christian-byrne · 2025-08-12T22:16:31Z

Minor conflict on the settings config and imports, sorry about that.

…actor

pythongosssss · 2025-08-14T19:05:36Z

Conflicts fixed!

christian-byrne

LGTM, this is great.

github-actions · 2025-08-14T21:54:04Z

@pythongosssss Backport to core/1.25 failed: Merge conflicts detected.

Please manually cherry-pick commit 4ca6220adf4961afacc1b1faac1c4ff8a8475054 to the core/1.25 branch.

Conflicting files

src/locales/ar/commands.json
src/locales/ar/main.json
src/locales/en/main.json
src/locales/es/main.json
src/locales/fr/main.json
src/locales/ja/main.json
src/locales/ko/main.json
src/locales/ru/main.json
src/locales/zh-TW/main.json
src/locales/zh/main.json

* Restructures the application menu - rename Workflow to File - move new & template items to top level - add View menu and related sub items Commands - add "active" state getter shown as checkmark in the menu Node side panel - add refresh node defs - change reset view icon Help center - change to use store for visibility Fixes - Fix bug with mouse down where if you drag mouse out, mouse up wasn't caught - Fix issue with canvas info setting not triggering a redraw on change * Fix missing translation warnings * Add separator under new * tidy * Update locales [skip ci] * fix some tests * fix * Hide icon if there is an active state within the menu item group * Update locales [skip ci] * Fix tests * Implement feedback - Remove queue, node lib, model lib, workflows, manager, help center - Add minimap, link visibility * Update locales [skip ci] * Add plus icon on "New" menu item * Update locales [skip ci] * Fix test * Fix translations * Update locales [skip ci] * Update locales [skip ci] --------- Co-authored-by: github-actions <[email protected]>

) (#5030) * Refactor app menu items (#4665) * Restructures the application menu - rename Workflow to File - move new & template items to top level - add View menu and related sub items Commands - add "active" state getter shown as checkmark in the menu Node side panel - add refresh node defs - change reset view icon Help center - change to use store for visibility Fixes - Fix bug with mouse down where if you drag mouse out, mouse up wasn't caught - Fix issue with canvas info setting not triggering a redraw on change * Fix missing translation warnings * Add separator under new * tidy * Update locales [skip ci] * fix some tests * fix * Hide icon if there is an active state within the menu item group * Update locales [skip ci] * Fix tests * Implement feedback - Remove queue, node lib, model lib, workflows, manager, help center - Add minimap, link visibility * Update locales [skip ci] * Add plus icon on "New" menu item * Update locales [skip ci] * Fix test * Fix translations * Update locales [skip ci] * Update locales [skip ci] --------- Co-authored-by: github-actions <[email protected]> * Update side toolbar menu (#4946) Side toolbar menu UI updates - Currently the template modal is very hidden. Many users do not find it - The current icons are quite aleatory **What**: - Add templates shortcut button - Add item label in normal size - Use custom icon Critical design decisions or edge cases that need attention: - Sidebar tabs registered using custom icons will have their associated command registed with an undefined icon (currently only string icons are accepted, not components). I couldn't see anywhere directly using this icon, but we should consider autogenerating an icon font so we can use classes for our custom icons (or locating and updating locations to support both icon types) Normal mode: <img width="621" height="1034" alt="image" src="https://github.com/user-attachments/assets/c1d1cee2-004e-4ff8-b3fa-197329b0d2ae" /> Small mode: <img width="176" height="325" alt="image" src="https://github.com/user-attachments/assets/3824b8f6-bc96-4e62-aece-f0265113d2e3" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-4946-Update-side-toolbar-menu-24d6d73d365081c5b2bdc0ee8b61dc50) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]> --------- Co-authored-by: pythongosssss <[email protected]> Co-authored-by: github-actions <[email protected]>

pythongosssss and others added 5 commits August 3, 2025 16:24

Fix missing translation warnings

2a1afe4

Add separator under new

d3891c5

tidy

af38f4e

Update locales [skip ci]

3b2e0b6

christian-byrne added the area:ui General user interface and experience improvements label Aug 4, 2025

pythongosssss and others added 18 commits August 9, 2025 10:36

fix some tests

1856eea

fix

8280087

Hide icon if there is an active state within the menu item group

1a54658

Merge remote-tracking branch 'origin/main' into pysssss/menu-item-ref…

effed58

…actor

Update locales [skip ci]

4b04c6d

Fix tests

7f1d45e

Merge branch 'pysssss/menu-item-refactor' of https://github.com/Comfy…

b2799c4

…-Org/ComfyUI_frontend into pysssss/menu-item-refactor

Merge remote-tracking branch 'origin/main' into pysssss/menu-item-ref…

8e701f8

…actor

Implement feedback

1820e93

- Remove queue, node lib, model lib, workflows, manager, help center - Add minimap, link visibility

Update locales [skip ci]

7c854a5

Add plus icon on "New" menu item

f4e061c

Merge branch 'pysssss/menu-item-refactor' of https://github.com/Comfy…

4c1fa05

…-Org/ComfyUI_frontend into pysssss/menu-item-refactor

Merge remote-tracking branch 'origin/main' into pysssss/menu-item-ref…

6db415e

…actor

Update locales [skip ci]

89944ce

Fix test

7bf162d

Merge branch 'pysssss/menu-item-refactor' of https://github.com/Comfy…

b84cb18

…-Org/ComfyUI_frontend into pysssss/menu-item-refactor

Fix translations

37b336e

Update locales [skip ci]

84eaace

pythongosssss marked this pull request as ready for review August 12, 2025 19:45

pythongosssss requested review from Yorha4D, KarryCharon, shinshin86 and a team as code owners August 12, 2025 19:45

pythongosssss requested a review from a team as a code owner August 12, 2025 19:45

christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch area:topbar-menu 1.25 labels Aug 12, 2025

pythongosssss and others added 2 commits August 14, 2025 18:55

Merge remote-tracking branch 'origin/main' into pysssss/menu-item-ref…

e5f8ae0

…actor

Update locales [skip ci]

778dcdc

christian-byrne approved these changes Aug 14, 2025

View reviewed changes

christian-byrne merged commit 4ca6220 into main Aug 14, 2025
2 checks passed

christian-byrne deleted the pysssss/menu-item-refactor branch August 14, 2025 21:53

christian-byrne mentioned this pull request Aug 15, 2025

1.26.3 #4995

Merged

christian-byrne mentioned this pull request Aug 15, 2025

[Release] v1.25.6 #5004

Merged

christian-byrne mentioned this pull request Aug 16, 2025

[backport] Refactor app menu items and update side toolbar (#4665, #4946) #5030

Merged

christian-byrne mentioned this pull request Aug 16, 2025

[release] Bump version to 1.25.8 #5031

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor app menu items #4665

Refactor app menu items #4665

pythongosssss commented Aug 3, 2025 •

edited

Loading

Uh oh!

JorgeR81 commented Aug 4, 2025 •

edited

Loading

Uh oh!

christian-byrne commented Aug 12, 2025

Uh oh!

pythongosssss commented Aug 14, 2025

Uh oh!

christian-byrne left a comment

Uh oh!

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

Uh oh!

Refactor app menu items #4665

Refactor app menu items #4665

Conversation

pythongosssss commented Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorgeR81 commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christian-byrne commented Aug 12, 2025

Uh oh!

pythongosssss commented Aug 14, 2025

Uh oh!

christian-byrne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

Uh oh!

pythongosssss commented Aug 3, 2025 •

edited

Loading

JorgeR81 commented Aug 4, 2025 •

edited

Loading