[feat] Make hotkey for exiting subgraphs configurable in user keybindings #4818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
force-pushed
the
feat/configurable-escape-subgraph
branch
from
18fad19 to
9ca8a64
Compare
|
github-actions
bot
requested review from
Yorha4D,
KarryCharon and
shinshin86
as code owners
Fixes #4208 - Escape hotkey is now configurable through the keybinding system. Added Exit Subgraph command that can be bound to any key combination. Escape key prioritizes closing dialogs before exiting subgraphs.
christian-byrne
force-pushed
the
feat/configurable-escape-subgraph
branch
from
f455df3 to
a8800b8
Compare
The test was overly mocked and provided little value beyond what's already covered by keybindingService tests and browser tests.
christian-byrne
force-pushed
the
feat/configurable-escape-subgraph
branch
from
98d03c8 to
4996a15
Compare
christian-byrne
added
needs-backport
Instead of navigating through the UI, directly set keybinding settings which is more reliable and faster.
christian-byrne
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2025
…ings (#4818) Co-authored-by: github-actions <[email protected]>
|
@christian-byrne Successfully backported to #4914 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4208
Makes the Escape hotkey for exiting subgraphs configurable through the keybinding system. Users can now rebind this key to their preference while maintaining proper dialog handling priority.
┆Issue is synchronized with this Notion page by Unito