Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Preload] Add startup validation API #658

Merged
merged 4 commits into from
Jan 17, 2025
Merged

[Preload] Add startup validation API #658

merged 4 commits into from
Jan 17, 2025

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Jan 17, 2025 •
edited by sync-by-unito bot
Loading

Preload

  • Adds the preload project portion of the validation PR, adding API methods under child objects:
    • Validation
    • uv
  • Adds TS types to preload.
  • Resolves a discard issue with an existing handler.

Shared

  • Adds IPC channel constants

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested a review from a team as a code owner January 17, 2025 02:51
huchenlei
huchenlei approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

src/preload.ts Outdated Show resolved Hide resolved
src/preload.ts Outdated Show resolved Hide resolved
@huchenlei huchenlei merged commit 9bedf7e into main Jan 17, 2025
6 checks passed
@huchenlei huchenlei deleted the validation-api branch January 17, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei