-
Notifications
You must be signed in to change notification settings - Fork 54
CBST2-06: Implement rate limiting for JWT auth failures #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jclapis
wants to merge
45
commits into
main
Choose a base branch
from
rate-limit-jwt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he source" This reverts commit 58c6117.
Co-authored-by: ltitanb <[email protected]>
…ip-bind-to-signer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a customizable setup to the signer module for rate limiting requests after repeated JWT authorization failures from a client. The implementation is simple: if a client fails JWT authorization X times, they are added to a cooldown and any subsequent requests will be denied until the cooldown completes.
The failure limit is controlled in the
[signer]
config withjwt_auth_fail_limit
, or with theSIGNER_JWT_AUTH_FAIL_LIMIT_ENV
environment variable.The cooldown timeout (in seconds) is controlled in the
[signer]
config withjwt_auth_fail_timeout_seconds
, or with theSIGNER_JWT_AUTH_FAIL_TIMEOUT_SECONDS_ENV
environment variable.As a side-effect, this also adds a unit testing setup for the Signer module since one wasn't in place yet. A test for this rate limiting behavior is included.