-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locations checkin #17
base: master
Are you sure you want to change the base?
Conversation
Looking good.
We could also get fancy with a custom As long as the mutations take an We're thinking that |
I added the name to the place... I was thinking the id of the placeDay could be place name + date for faster lookup if needed. We don't really need two separate ids? To me it comes more natural to have logContact and logPlace separate... you might have met with a person somewhere... but you might have went shopping and met no one. Depends how you want to enforce data entry on frontend... can you meet someone and not not input place... can you go places and not contact people... I would split them into more queries for the sake of simplicity instead of having a bunch of case statement in the cypher query... have some cases statement in JS :) |
Agreed.
Agreed for the same reason you've given.
All for multiple, simpler mutations. As we won't know which mutations will be called first ( We'll have to think about editing these entries too: Excited to see where we take this. Thanks for your help. |
@all-contributors please add @tomasonjo for code |
I've put up a pull request to add @tomasonjo! 🎉 |
I have added the place and placeDay types in the schema...
Don't mind the cypher query just yet as we can fix it.
Anyway, do you want to add any fields to these two types, and do you have in mind how would the input for mutation look like?