Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib: Add a test #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

183amir
Copy link

@183amir 183amir commented Jan 27, 2017

This test makes sure all matplotlib dependencies are already installed
which would prevent ContinuumIO/anaconda-issues#1379 (comment)
from happening.

This test makes sure all matplotlib dependencies are already installed
which would prevent ContinuumIO/anaconda-issues#1379 (comment)
from happening.
@ilanschnell
Copy link
Contributor

Thanks for pointing this out. The problem is that when adding setuptools as a test dependency, you cannot test whether or not the package breaks if setuptools is not installed, and I always try to not list setuptools as a dependency when it is not necessary. I'll have to think about this.

@183amir
Copy link
Author

183amir commented Jan 30, 2017

Maybe we can run this command in the build.sh script?

@ilanschnell
Copy link
Contributor

Yes! That seems like the right solution to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants