New error type #2500
New error type #2500
Conversation
|
Also the change on the shell files is very smol (just replacing |
|
Please I literally let the whole test suite run locally, how were these errors not caught |
Even the |
Probably typo'd when executing. Taking care of it. |
| #!/bin/bash | ||
| #!/usr/bin/env bash |
There was a problem hiding this comment.
As a fellow NixOS user (not on the work laptop though), I salute you 🫡
contracts/hackatom/src/errors.rs
Outdated
| Std(#[from] StdError), | ||
| Std(StdError), |
There was a problem hiding this comment.
Can we not use #[from] anymore?
There was a problem hiding this comment.
It's because of the requirement of thiserror. If you want to use the #[from] feature, it has to implement core::error::Error + Send + Sync (which we can't fulfill because of trait blanket impls; same reason why anyhow can't implement the error trait)
There was a problem hiding this comment.
Ah, that's a bit sad. What if we used manual (or macro assisted) impls for all our error types instead of the blanket impl?
| // "mom, can we have specialization?" | ||
| // "we have specialization at home" | ||
| // specialization at home: |
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Now with 99% less enum cases. Add that to the cerial packaging as a selling point.
Closes #2469