Skip to content

Add Transfer handling to IBCDestinationCallbackMsg #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2025
Merged

Add Transfer handling to IBCDestinationCallbackMsg #675

merged 3 commits into from
May 26, 2025

Conversation

chipshort
Copy link
Collaborator

companion of CosmWasm/cosmwasm#2484

kulikthebird
kulikthebird approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the json size tests! Looks good, only one comment

@chipshort chipshort changed the title Add funds to IBCDestinationCallbackMsg Add Transfer handling to IBCDestinationCallbackMsg May 22, 2025
kulikthebird
kulikthebird approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful update, thanks! The JSON size of the new structure is implicitly tested, so it's good to go.

@chipshort chipshort merged commit d1bff6f into main May 26, 2025
15 checks passed
@chipshort chipshort deleted the co/ibc-callbacks-funds branch May 26, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulikthebird kulikthebird kulikthebird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chipshort @kulikthebird