-
Notifications
You must be signed in to change notification settings - Fork 69
Remove search and post #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove search and post #1549
Conversation
Pull Request Test Coverage Report for Build 928e71fe-0b76-473c-9b8e-15c9e1c61bacDetails
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akarki2005 this is a good start, but there's even more code to delete. You mainly focused work on the front-end, but in the back-end the routes "post"
, "post-progress"
, and "timesearch"
can also be deleted. Note that you should be looking at files in the back-end with names like "Post" and "Search" as well.
@@ -40,7 +40,7 @@ | |||
- Removed `privacy` route and codes related to it | |||
- Improved general testing infrastructure | |||
- Added test cases for the index function in `Controllers/Course` | |||
- Added test cases for the depts function in `Controllers/Course` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general you should not delete old Changelog entries, even if they are no longer applicable.
Proposed Changes
Currently, the
search
andpost
components are not enabled by default in the Courseography application, as their use has been deprecated. In spite of this, the components remain in the codebase, and in addition, the/depts
route and its related functions and tests remain as well. This change seeks to clean up the codebase by removing these two unused components, as well as any related routing and backend modules.Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)