Skip to content

Remove search and post #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

akarki2005
Copy link
Contributor

@akarki2005 akarki2005 commented May 20, 2025

Proposed Changes

Currently, the search and post components are not enabled by default in the Courseography application, as their use has been deprecated. In spite of this, the components remain in the codebase, and in addition, the /depts route and its related functions and tests remain as well. This change seeks to clean up the codebase by removing these two unused components, as well as any related routing and backend modules.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • [N/A] I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • [N/A] I have updated the project documentation, if applicable.
    • This is required for new features.
  • [N/A] If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 928e71fe-0b76-473c-9b8e-15c9e1c61bac

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 40.563%

Totals Coverage Status
Change from base Build 89affbdb-04b4-4516-8200-f96ebbffa86b: -0.2%
Covered Lines: 628
Relevant Lines: 1514

💛 - Coveralls

@akarki2005 akarki2005 requested a review from david-yz-liu May 21, 2025 00:27
@akarki2005 akarki2005 marked this pull request as ready for review May 21, 2025 00:27
Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akarki2005 this is a good start, but there's even more code to delete. You mainly focused work on the front-end, but in the back-end the routes "post", "post-progress", and "timesearch" can also be deleted. Note that you should be looking at files in the back-end with names like "Post" and "Search" as well.

@@ -40,7 +40,7 @@
- Removed `privacy` route and codes related to it
- Improved general testing infrastructure
- Added test cases for the index function in `Controllers/Course`
- Added test cases for the depts function in `Controllers/Course`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general you should not delete old Changelog entries, even if they are no longer applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants