Specs/grains observation #1573
Merged
Specs/grains observation #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atching up events for partitions after retrying or handling failed partitions
… so that it saves its grain state after it is changed
…tate and can handle events in a specified range instead of always all events
…ries starting the docker container up to 10 times. This is helpfull when running integration tests back to back
…ecs/grains-observation
…ecs/grains-observation
woksin
commented
Nov 28, 2024
|
Follow up tasks from this is to go over the job system with specs and then move over to through integration testing |
einari
reviewed
Nov 29, 2024
einari
reviewed
Nov 29, 2024
Source/Kernel/Grains/Observation/Jobs/HandleEventsForPartition.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Einar Ingebrigtsen <[email protected]>
Co-authored-by: Einar Ingebrigtsen <[email protected]>
einari
reviewed
Nov 29, 2024
einari
approved these changes
Nov 29, 2024
woksin
force-pushed
the
specs/grains-observation
branch
from
c894173 to
214a772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the process of adding specs to the Observation system many smaller issues were discovered and fixed. Along with general code cleanup and refactoring.
Added
Changed
Fixed
JobStepdid not save state when pausedRemoved
Handledfrom ObserverState counting the number of handled events. This can be done differently in the future