Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/error with restarting #1668

Merged
merged 31 commits into from
Jan 22, 2025
Merged

Fix/error with restarting #1668

merged 31 commits into from
Jan 22, 2025

Conversation

woksin
Copy link
Contributor

@woksin woksin commented Jan 21, 2025 •
edited by einari
Loading

Fixed

@github-actions GitHub Actions
Copy link
Contributor

NuGet packages for this PR, e.g. Cratis:
https://github.com/cratis/chronicle/packages/1655206?version=10.9.4-pr1668.114a6d7

woksin and others added 15 commits January 21, 2025 11:12
@woksin @einari
Remove unneeded states from ObserverRunningState and remove NextEvent…
cb29ce7 
…SequenceNumberForEventTypes from ObserverState

Co-authored-by: [email protected] <[email protected]>
@woksin
Start on adding more integration tests
f8f6e9b
@woksin
Change Observer state
e050179
@woksin
Remove Indexing state
e99d8a6
@woksin
WIP fix state machine for Observer
78e9f09
@einari
Removing references to Indexing and CatchUp
98d3376
@einari
Removing CatchUp as an allowed transition
a5b8de4
@einari
Removing explicit CatchUp state
971e5fa
@einari @woksin
Downgrading Xunit
bf04755 
Co-authored-by: Sindre Alstad Wilting <[email protected]>
@einari
Up and running with the new simplified routing and state management
724a9f1
@einari
Removing traits
1572752
@einari
Removing specs for Catchup, since this state doesn't exist anymore
592eb6e
@einari
Updated states
8ec8824
@einari
Fixing specs after refactoring
930cb51
@woksin
Fixed compilation issue with spec
b105e67
@github-actions GitHub Actions
Copy link
Contributor

NuGet packages for this PR, e.g. Cratis:
https://github.com/cratis/chronicle/packages/1655206?version=10.9.4-pr1668.6f65f4a

@github-actions GitHub Actions
Copy link
Contributor

NuGet packages for this PR, e.g. Cratis:
https://github.com/cratis/chronicle/packages/1655206?version=10.9.4-pr1668.2d0edf0

@github-actions GitHub Actions
Copy link
Contributor

NuGet packages for this PR, e.g. Cratis:
https://github.com/cratis/chronicle/packages/1655206?version=10.9.4-pr1668.d7f1cae

@github-actions GitHub Actions
Copy link
Contributor

Docker Image for this PR:
https://ghcr.io/cratis/chronicle:10.9.4-pr1668.d7f1cae

docker run ghcr.io/cratis/chronicle:10.9.4-pr1668.d7f1cae

@github-actions GitHub Actions
Copy link
Contributor

NuGet packages for this PR, e.g. Cratis:
https://github.com/cratis/chronicle/packages/1655206?version=10.9.4-pr1668.cf827f8

@einari einari added the patch label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for this PR:
https://ghcr.io/cratis/chronicle:10.9.4-pr1668.cf827f8

docker run ghcr.io/cratis/chronicle:10.9.4-pr1668.cf827f8

@github-actions GitHub Actions
Copy link
Contributor

NuGet packages for this PR, e.g. Cratis:
https://github.com/cratis/chronicle/packages/1655206?version=10.9.4-pr1668.3228f34

@github-actions GitHub Actions
Copy link
Contributor

Docker Image for this PR:
https://ghcr.io/cratis/chronicle:10.9.4-pr1668.3228f34

docker run ghcr.io/cratis/chronicle:10.9.4-pr1668.3228f34

@einari
Return from ReceiveReminder if observer is not subscribed, no point i…
fe3c01b 
…n creating a job for a disconnected subscriber
@github-actions GitHub Actions
Copy link
Contributor

NuGet packages for this PR, e.g. Cratis:
https://github.com/cratis/chronicle/packages/1655206?version=10.9.4-pr1668.810d919

@github-actions GitHub Actions
Copy link
Contributor

Docker Image for this PR:
https://ghcr.io/cratis/chronicle:10.9.4-pr1668.810d919

docker run ghcr.io/cratis/chronicle:10.9.4-pr1668.810d919

@einari einari marked this pull request as ready for review January 22, 2025 13:31
@einari einari merged commit a0db485 into main Jan 22, 2025
17 of 18 checks passed
@einari einari deleted the fix/error-with-restarting branch January 22, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einari einari einari approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Observer Routing does not take into consideration Observers with Replaying or CatchingUp Partitions
2 participants
@woksin @einari