Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
ConnectionService
during keep alive. If it fails within the keep alive loop, it will keep on going and not just die. Added logging if this occurs.AppendedEventsQueue
to ensure the queue task is always alive, and if it stops it will be recreated. Logging the errors if they occur.Handle()
on theObserver
fails, theAppendedEventsQueue
will catch this and retry indefinitely. Any failures happening within the Observer should be handled by itself and rais failed partitions. But not being able to reach theObserver
should not mean we move on to the next event. This might need a circuit breaker. For now we consider this scenario as a transient failure.Active
state. This is to prevent handling happening while transitioning between states.