Fix/job resume #1704
Merged
Fix/job resume #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of state machine state. We were just lucky that when starting jobs that we had stored the correct state on the Observer most of the time.
…n integration test because it can occationally fail because GetState is interleaved method
…so rework Start so that it is waits for the whole process of starting all jobsteps to be finished before returning. This makes the code more simple and safe because we don't have to think about being in multiple grain contexts in a single logical method execution and we don't need to use task completion sources and task continue with manually anymore. We can do this now because I made JobsManager reentrant so that we can perform multiple actions on separate jobs at the same time, which in my opinion makes more sense
…ests and then it is nice to wait for the Observer to be finished processing messages
…art behaves as Resume would
…PreparingJob state
…check stopped steps
…mplementing class, not the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a lot of issues internally with the JobSystem that should greatly impact the stability and resilience of the system.
Changed
Fixed