Fixed handling of origin when allow_credentials enabled #985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are to things to start with:
Origin
header.Access-Control-Allow-Credentials
headers.Access-Control-Allow-Credentials=true
andAccess-Control-Allow-Origin=*
. (source)Currently, the master brunch's response to OPTIONS request contains an
Access-Control-Allow-Origin=
, which is interpreted incorrectly by most browsers. We can't fix it by simply checking for the presence of anOrigin
header in the request, due to the possibility of sending out bothAccess-Control-Allow-Credentials=true
andAccess-Control-Allow-Origin=*
. The simple yet correct way to fix that behavior is to specifically check that the request being answered is not anOPTIONS
one. Such a check is implemented in this pull request. There is also a test added that checks for incorrectOrigins
-Credentials
behavior.