Skip to content

Commit

Permalink
Upgrade ember-async-data (#147)
Browse files Browse the repository at this point in the history
* Upgrade ember-asyncn-data

* Add changeset

* Downgrade lockfile to v7 of pnpm

* Remove extra thiseseseses
  • Loading branch information
NullVoxPopuli authored Jun 12, 2023
1 parent 67b1e02 commit 6984523
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 14 deletions.
5 changes: 5 additions & 0 deletions .changeset/rotten-turkeys-build.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'ember-headless-form': patch
---

Upgrade dependency: ember-async-data to 1.0.1
2 changes: 1 addition & 1 deletion packages/ember-headless-form/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@babel/runtime": "^7.20.7",
"@embroider/addon-shim": "^1.0.0",
"@embroider/util": "^1.10.0",
"ember-async-data": "^0.7.0",
"ember-async-data": "^1.0.1",
"ember-modifier": "^4.1.0",
"tracked-built-ins": "^3.1.0"
},
Expand Down
5 changes: 2 additions & 3 deletions packages/ember-headless-form/src/components/headless-form.gts
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ export default class HeadlessFormComponent<
async _validate(): Promise<ErrorRecord<FormData<DATA>>> {
const promise = this.validate();

this.validationState = new TrackedAsyncData(promise, this);
this.validationState = new TrackedAsyncData(promise);

return promise;
}
Expand Down Expand Up @@ -459,8 +459,7 @@ export default class HeadlessFormComponent<
if (!this.hasValidationErrors) {
if (this.args.onSubmit) {
this.submissionState = new TrackedAsyncData(
this.args.onSubmit(this.effectiveData),
this
this.args.onSubmit(this.effectiveData)
);
}
} else {
Expand Down
20 changes: 11 additions & 9 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"broccoli-asset-rev": "^3.0.0",
"concurrently": "^8.0.0",
"ember-a11y-testing": "^5.2.0",
"ember-async-data": "^0.7.0",
"ember-async-data": "^1.0.1",
"ember-auto-import": "^2.5.0",
"ember-changeset": "^4.1.2",
"ember-cli": "~4.12.0",
Expand Down

0 comments on commit 6984523

Please sign in to comment.