Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update misleading description header #48

Merged

Conversation

danbfield
Copy link
Contributor

This PR resolves a misleading user experience regarding the job description. The "Description" header was rendering even if job.description did not exist (e.g. ""), which gave the impression that the target host(s) information was the description, which it isn't.

This PR does a couple of things;

  • Moves the "Description" into the job.description exists logic
  • Adds a test to assert this
  • Bumps Eslint & Vitest versions, as this was the first test using DOM assertions

Hopefully this is clear from the video!

388464178-a97e4620-b104-45e2-b40b-c412a9ba65fc.mov

@dbutterfield77 dbutterfield77 merged commit e0b1725 into CrowdStrike:main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants