Clear securityCode viewValue on switchPayment.

CruGlobal · Nov 19, 2024 · 67b31b4 · 67b31b4
1 parent 75d2d3b
commit 67b31b4
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 12 deletions.
diff --git a/src/app/checkout/step-2/existingPaymentMethods/existingPaymentMethods.component.js b/src/app/checkout/step-2/existingPaymentMethods/existingPaymentMethods.component.js
@@ -141,6 +141,9 @@ class ExistingPaymentMethodsController {
   }
 
   switchPayment () {
+    this.creditCardPaymentForm.securityCode.$setViewValue('')
+    this.creditCardPaymentForm.securityCode.$render()
+    console.log(this.selectedPaymentMethod)
     this.onPaymentChange({ selectedPaymentMethod: this.selectedPaymentMethod })
     if (this.selectedPaymentMethod?.['bank-name']) {
       // This is an EFT payment method so we need to remove any fee coverage

diff --git a/src/app/checkout/step-2/existingPaymentMethods/existingPaymentMethods.component.spec.js b/src/app/checkout/step-2/existingPaymentMethods/existingPaymentMethods.component.spec.js
@@ -26,6 +26,17 @@ describe('checkout', () => {
           enableContinue: jest.fn(),
           onPaymentFormStateChange: jest.fn(),
           cartData: { items: [] },
+          creditCardPaymentForm: {
+            securityCode: {
+              $valid: true,
+              $validators: {
+                minLength: (value) => cruPayments.creditCard.cvv.validate.minLength(value),
+                maxLength: cruPayments.creditCard.cvv.validate.maxLength
+              },
+              $setViewValue: jest.fn(),
+              $render: jest.fn(),
+            }
+          }
         })
       }))
 
@@ -336,18 +347,6 @@ describe('checkout', () => {
       })
 
       describe('addCustomValidators', () => {
-        beforeEach(() => {
-          self.controller.creditCardPaymentForm = {
-            securityCode: {
-              $valid: true,
-              $validators: {
-                minLength: (value) => cruPayments.creditCard.cvv.validate.minLength(value),
-                maxLength: cruPayments.creditCard.cvv.validate.maxLength
-              }
-            }
-          }
-        })
-
         it('should add validator functions to creditCardPaymentForm.securityCode', () => {
           expect(size(self.controller.creditCardPaymentForm.securityCode.$validators)).toEqual(2)
           expect(typeof self.controller.creditCardPaymentForm.securityCode.$validators.minLength).toBe('function')
@@ -375,6 +374,13 @@ describe('checkout', () => {
           self.controller.$scope.$apply()
           expect(self.controller.enableContinue).toHaveBeenCalledWith({ $event: false })
         })
+
+        it('should reset securityCode viewValue on switch payment', () => {
+          self.controller.creditCardPaymentForm.securityCode.$viewValue = '123'
+          self.controller.switchPayment()
+          expect(self.controller.creditCardPaymentForm.securityCode.$setViewValue).toHaveBeenCalledWith('')
+          expect(self.controller.creditCardPaymentForm.securityCode.$render).toHaveBeenCalled()
+        })
       })
     })
   })