Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SSA expectations for recent versions of Kubernetes #3767

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Update SSA expectations for recent versions of Kubernetes #3767

merged 2 commits into from
Oct 31, 2023

Conversation

cbandy
Copy link
Member

@cbandy cbandy commented Oct 31, 2023

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • Testing enhancement

What is the current behavior (link to any open issues here)?

An SSA test is failing because the Kubernetes API changed.

What is the new behavior (if this is a feature change)?

The test passes.

benjaminjb
benjaminjb approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's introduced in 1.25.15 and fixed in 1.26.10 and 1.27.7?

@cbandy
Copy link
Member Author

cbandy commented Oct 31, 2023

It's fixed in those versions, so we expect the bug in everything ahead of them.

@cbandy
Relax an expectation in the Ticker tests
eff3f4a 
The test is racy and occasionally fails with "4 (int) != 3 (int)".
@cbandy cbandy requested a review from benjaminjb October 31, 2023 19:13
@cbandy cbandy merged commit b50135f into CrunchyData:master Oct 31, 2023
14 checks passed
@cbandy cbandy deleted the ssa-expectations branch October 31, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminjb benjaminjb benjaminjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbandy @benjaminjb