Update controller-gen and remove our code generation workarounds #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbandy
force-pushed
the
controller-gen
branch
from
596225e to
60406a3
Compare
tjmoore4
reviewed
Oct 21, 2024
tjmoore4
approved these changes
Oct 21, 2024
cbandy
force-pushed
the
controller-gen
branch
from
60406a3 to
a2f3798
Compare
jmckulk
approved these changes
Oct 22, 2024
benjaminjb
approved these changes
Oct 22, 2024
cbandy
commented
Oct 23, 2024
Comment on lines
-3104
to
+3113
| required: | ||
| - accessModes | ||
| - resources | ||
| type: object | ||
| x-kubernetes-validations: | ||
| - message: missing accessModes | ||
| rule: has(self.accessModes) && size(self.accessModes) | ||
| > 0 | ||
| - message: missing storage request | ||
| rule: has(self.resources) && has(self.resources.requests) | ||
| && has(self.resources.requests.storage) |
There was a problem hiding this comment.
🤔 This affects the API reference documentation. The required column changes from yes to no.
kubectl explain also calls out required:
$ kubectl explain postgresclusters.spec.instances.dataVolumeClaimSpec
…
FIELDS:
accessModes <[]string> -required-
accessModes contains the desired access modes the volume should have.
…
Updates to the latest controller-gen release. CRDs and RBAC have been regenerated, and "namespace" has been removed from the markers in the Patroni and pgBackRest Go files (it was no longer providing much benefit since the go code already cleanly organizes the RBAC, and changes to controller controller-gen had the potential to break RBAC generation as a result of its use). Issue: PGO-1748
These are not compatible with Red Hat's current requirements. Issue: PGO-1046
Recent controller-gen does the resource consolidation for us, and recent Kustomize can change ClusterRole to Role with a patch directive. Ruby is no longer required during development! Issue: PGO-1748
Recent controller-gen does this for us. Issue: PGO-1748
Issue: PGO-1748
The JSON patch was awkward to maintain, and we forgot to update it when we added PVCs to our APIs. I considered defining these rules on a shared Go type in our API package, but I did not like the type conversion it requires in our controller and test code. Issue: PGO-1748
This is easier to manage in one place and is the last modification we're making to CRDs as they are generated. A future commit is free to remove the Kutomiziations entirely. Issue: PGO-1046 Issue: PGO-1748
Recent versions of controller-gen are able to describe our CRDs! Issue: PGO-1748
cbandy
force-pushed
the
controller-gen
branch
from
a2f3798 to
07c46eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent controller-gen does everything we had to do with Ruby and Kustomize.
This removes the
build/crd,config/singlenamespace, andinstallersdirectories. In their place, I've added two validation rules to most of our PVC specs. The pgAdmin APIs don't have these rules, and adding them causes a test to fail.Checklist:
Type of Changes:
Other Information: