Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create warning event when postgres version is EOL. #4028

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dsessler7
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

When a user has a postgrescluster that is using an End-Of-Life version of postgres, we don't warn them.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

We add a warning event to the postgrescluster if the postgres version is End-Of-Life.

Other Information:

Copy link
Member

@cbandy cbandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good. I'll let others comment on the warning reason or text.

internal/postgres/config.go Outdated Show resolved Hide resolved
internal/postgres/config_test.go Outdated Show resolved Hide resolved
@dsessler7 dsessler7 force-pushed the eol_postgres_warning branch from b17d8f3 to 55fcf71 Compare November 6, 2024 00:14
@dsessler7 dsessler7 force-pushed the eol_postgres_warning branch from 55fcf71 to 068d5b9 Compare November 6, 2024 22:09
Copy link
Member

@cbandy cbandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last pile of nitpicks about formatting messages. LGTM

internal/controller/postgrescluster/controller.go Outdated Show resolved Hide resolved
@dsessler7 dsessler7 force-pushed the eol_postgres_warning branch from 068d5b9 to 16fcbde Compare November 7, 2024 19:33
@dsessler7 dsessler7 force-pushed the eol_postgres_warning branch from 16fcbde to 422e89b Compare November 7, 2024 19:36
@dsessler7 dsessler7 merged commit 82097e7 into CrunchyData:main Nov 7, 2024
16 checks passed
@dsessler7 dsessler7 deleted the eol_postgres_warning branch November 7, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants