Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all feature gates during development #4062

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Enable all feature gates during development #4062

merged 2 commits into from
Dec 23, 2024

Conversation

cbandy
Copy link
Member

@cbandy cbandy commented Dec 20, 2024

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • Testing enhancement

@cbandy
Enable all feature gates during development
7952ee1 
Issue: PGO-1046
@cbandy
Move CGO requirement to the effected code
c7b9ba4 
Forcing `CGO_ENABLED=1` in the Makefile is too far away from the reason
we do it. Use a build constraint instead with a comment and link.

See: 67fe735
@cbandy cbandy merged commit a2c6c48 into CrunchyData:main Dec 23, 2024
17 checks passed
@cbandy cbandy deleted the development-gates branch December 23, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmckulk jmckulk jmckulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbandy @jmckulk