Wait only for local write of controller SQL #4070
Merged
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Postgres replication is broken and synchronous commit is enabled, the controller blocks waiting for a remote write that will never happen. This change allows the controller to return from SQL writes and repair replication. Issue: PGO-1592
tjmoore4
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
When Postgres replication is broken and synchronous commit is enabled, the controller blocks waiting for a remote write that will never happen.
What is the new behavior (if this is a feature change)?
This change allows the controller to return from SQL writes and repair replication.
Other Information:
Issue: PGO-1592