Merge pull request #499 from Cysharp/hadashiA/fix-completion-source-r…

…etval Fix conditions for UniTaskCompletionSourceCore.TrySet* to be true
Cysharp · Sep 14, 2023 · 8a022ee · 8a022ee
2 parents 6a89ea8 + 50ad2ee
commit 8a022ee
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskCompletionSource.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskCompletionSource.cs
@@ -137,8 +137,8 @@ public bool TrySetResult(TResult result)
                 if (continuation != null || Interlocked.CompareExchange(ref this.continuation, UniTaskCompletionSourceCoreShared.s_sentinel, null) != null)
                 {
                     continuation(continuationState);
-                    return true;
                 }
+                return true;
             }
 
             return false;
@@ -165,8 +165,8 @@ public bool TrySetException(Exception error)
                 if (continuation != null || Interlocked.CompareExchange(ref this.continuation, UniTaskCompletionSourceCoreShared.s_sentinel, null) != null)
                 {
                     continuation(continuationState);
-                    return true;
                 }
+                return true;
             }
 
             return false;
@@ -184,8 +184,8 @@ public bool TrySetCanceled(CancellationToken cancellationToken = default)
                 if (continuation != null || Interlocked.CompareExchange(ref this.continuation, UniTaskCompletionSourceCoreShared.s_sentinel, null) != null)
                 {
                     continuation(continuationState);
-                    return true;
                 }
+                return true;
             }
 
             return false;