Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TriggerEvent problem with iterate breaking on Remove when it has multiple handlers #487

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

hadashiA
Copy link
Contributor

@hadashiA hadashiA commented Sep 1, 2023

After merging #445 , TriggerEvent test was broken... 🙏

Problem:

  • In h.Next, In the loop of TriggerEvent.SetResult
    • if Remove(h.Next), next is unreliable.
  • Also, .SetCompleted , .SetError, .SetCancelled needs to be similar fixes.

Fix:

  • If it removes itself, iteratingNode instance variable is rewritten to refer to iteratingNode instead of h.Next.

@hadashiA
Copy link
Contributor Author

hadashiA commented Sep 1, 2023

📝
Oh..., it looks like Linq/PublishTest is hunging up.
I'd like to revert #445 once, as it seems like it would be a pain to fix right away..

Reverted: #488

@hadashiA
Copy link
Contributor Author

hadashiA commented Sep 2, 2023

I found the cause, merged #445 and added more fixes. The test passed.

@neuecc
Copy link
Member

neuecc commented Sep 8, 2023

hope to work correctly:)

@hadashiA hadashiA merged commit c170af5 into master Sep 8, 2023
4 checks passed
@hadashiA hadashiA deleted the hadashiA/fix-test branch September 8, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants