Add EndOfFrame implementation using UnityEngine.Awaitable
#496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadashiA
commented
Sep 7, 2023
| @@ -75,6 +75,12 @@ public static UniTask NextFrame(PlayerLoopTiming timing, CancellationToken cance | |||
| return new UniTask(NextFramePromise.Create(timing, cancellationToken, out var token), token); | |||
| } | |||
|
|
|||
| #if UNITY_2023_1_OR_NEWER | |||
| public static async UniTask WaitForEndOfFrame(CancellationToken cancellationToken = default) | |||
There was a problem hiding this comment.
I have done a easy implementation that uses async.
Should I consider adding Awaitable.ToUniTask()?
📝 But Awaitable is has so few features that converting it to IUniTaskSource could be inefficient.
|
EndOfFrame thing is mentioned a lot in the ReadMe, I'd like to see an addendum in the ReadMe about the behavior in Unity 2023.1 and later. |
|
I've updated the README ! |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, MonoBehaviour is required to implement EndOfFrame, but Awaitable.EndOfFrameAsync is available from Unity 2023.1.