FSR-1159 | sonar issues

DEFRA · Mar 21, 2024 · 15dc33c · 15dc33c
1 parent 2c1f209
commit 15dc33c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/models/rloi.js b/lib/models/rloi.js
@@ -22,7 +22,7 @@ function removePostfix (name) {
 }
 
 async function fetchStation (s3, bucket, key) {
-  return await s3.getObject({
+  return s3.getObject({
     Bucket: bucket,
     Key: key
   })
@@ -57,6 +57,8 @@ function setValueItem (index, res, setOfValues) {
 module.exports = {
   async save (value, bucket, key, client, s3) {
     let processed = 0
+    const concurrence = 3
+    const processedValueDecimalPlace = 3
 
     const valuesCount = getValuesCount(value.EATimeSeriesDataExchangeFormat.Station)
 
@@ -73,7 +75,7 @@ module.exports = {
         item.$.telemetryRegion = item.$.region
         item.$.region = regions[item.$.region] ? regions[item.$.region] : item.$.region
 
-        await directly(3, item.SetofValues.map(setOfValues => async () => {
+        await directly(concurrence, item.SetofValues.map(setOfValues => async () => {
           let station
 
           try {
@@ -134,7 +136,7 @@ module.exports = {
               if (setOfValues.$.parameter === 'Water Level') {
                 // Subtract value if post process required
                 if (station.Post_Process.toLowerCase() === 'y' || station.Post_Process.toLowerCase() === 'yes') {
-                  values[i].processed_value = station.Subtract ? parseFloat(util.toFixed(values[i].value - parseFloat(station.Subtract), 3)) : values[i].value
+                  values[i].processed_value = station.Subtract ? parseFloat(util.toFixed(values[i].value - parseFloat(station.Subtract), processedValueDecimalPlace)) : values[i].value
                 }
                 if (!util.isNumeric(values[i].processed_value)) {
                   values[i].processed_value = null