Raiding units aren't flagged inactive, update code and docs #4948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add(DF unsets theUnits::isInPlay
fn to checkisActive
then scanunits.active
. Useful when you've got a unit pointer, but you don't know if it's in the active units vector.inactive
flag a few ticks after raiding units leave the map.)Updated some code and docs using this info. I would've changed the
isActive
function, but there may be performance concerns. Would be great if Bay12 could just use a flag for this, but we can't count on raiding bugs being fixed this decade.Made
getUnitsInBox
rule out inactive units by default, since death and map edge locations aren't where the unit actually is.