Skip to content

Fix potential vulnerable cloned function #5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

npt-1707
Copy link

Hi Development Team,

I identified a potential vulnerability in a clone function luaG_runerror() in depends/lua/src/ldebug.c sourced from lua/lua. This issue, originally reported in CVE-2022-33099, was resolved in the repository via this commit lua/lua@42d4058.

This PR applies the corresponding patch to fix the vulnerabilities in this codebase.

Please review at your convenience. Thank you!

@silverwing235
Copy link

Duplicate of #5465

@ab9rf
Copy link
Member

ab9rf commented May 19, 2025

This isn't a duplicate of #5465; however, the patch is based on a change in 5.4 and as we're on 5.3 I am not going to blithely apply it without more information. Given the low importance of this change, I'm not inclined to put out a lot of effort doing this.

Let me also point out that this is a buffer overrun, which in our context would mean that a Lua script author could potentially use this to run local code. As a Lua script author already has the unlimited ability to run local code anyway, all this amounts to is that there is a small risk that extremely stupid Lua code could cause an application crash. Obviously, this is not something we care all that terribly much about, and so the effort that we'll go to to investigate whether this change is worth applying is very limited.

I'm therefore not recommend this be merged until someone has confirmed that the change proposed is appropriate for Lua 5.3, either by examining the differential between 5.3 and 5.4, or by testing it on our platform. I very much doubt that the OP has done either of these things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants