Czech translation #42
Conversation
There was a problem hiding this comment.
Hi Pavel!
I've finally managed to have a look at your translations. In general, I like it. Well done. I've added few (mostly nitpicking) comments / improvement suggestions.
P.S.
Seems like DFRobot team doesn't want to include the BLE part. I'd suggest you drop those changes for now and focus on covering the officially released functionality.
| "maqueen.readPatrol": "Načte digitální hodnotu ze senzoru čáry (1 = čára přítomna, 0 = čára není přítomna).", | ||
| "maqueen.readPatrol|param|patrol": "senzor čáry, např. Patrol.PatrolLeft", | ||
| "maqueen.servoRun": "Nastaví úhel natočení servomotoru.", | ||
| "maqueen.writeLED": "Zapne, nebo vypne ybranou LED.", |
There was a problem hiding this comment.
There's a typo (missing letter 'v') here. You meant to write "Zapne, nebo vypne vybranou LED."
| "maqueen.motorRun|param|speed": "rychlost otáčení, např. 100", | ||
| "maqueen.motorStop": "Zastaví vybraný motor.", | ||
| "maqueen.motorStop|param|motors": "motor, který chceš zastavit", | ||
| "maqueen.readPatrol": "Načte digitální hodnotu ze senzoru čáry (1 = čára přítomna, 0 = čára není přítomna).", |
There was a problem hiding this comment.
I'd rather suggest to use "logickou" instead of "digitální". All numbers micro:bit internally works with are digital (i.e. non-analog). However, what the term "digitální" represents in Czech is much broader than what is meant in this context. It's even indicated by Voltage.High and Voltage.Low enums.
This will also make your translation consistent with MakeCode translating "read digital" to "logická hodnota z pinu".
| "maqueen.Ultrasonic": "Vrátí vzdálenost robota od překážky v cm.", | ||
| "maqueen.ltEvent": "Spustí obsah bloku, pokud zvolený senzor čáry najde nebo nenajde čáru.", | ||
| "maqueen.ltEvent|param|value": "senzor čáry, např. Patrol1.PatrolLeft", | ||
| "maqueen.ltEvent|param|vi": "digitální hodnota senzoru čáry, např. Voltage.High", |
There was a problem hiding this comment.
Consider using "logická" instead of "digitální". Reasoning is the same as for maqueen.readPatrol
| "Maqueen_V5.patrolling": "Zapne nebo vypne sledování čáry.", | ||
| "Maqueen_V5.patrolling|param|patrol": "stav sledování čáry, např. Patrolling.ON.", | ||
| "Maqueen_V5.readLightIntensity": "Načte intenzitu levé, nebo pravé LED.", | ||
| "Maqueen_V5.readPatrol": "Načte digitální hodnotu ze senzoru čáry (1 = čára přítomna, 0 = čára není přítomna).", |
There was a problem hiding this comment.
Consider using "logickou" instead of "digitální". Reasoning is the same as for maqueen.readPatrol
| "Maqueen_V5.patrolling|param|patrol": "stav sledování čáry, např. Patrolling.ON.", | ||
| "Maqueen_V5.readLightIntensity": "Načte intenzitu levé, nebo pravé LED.", | ||
| "Maqueen_V5.readPatrol": "Načte digitální hodnotu ze senzoru čáry (1 = čára přítomna, 0 = čára není přítomna).", | ||
| "Maqueen_V5.readPatrolData": "Načte analogovou hodnotu ze senzoru čáry v rozsahu od -128 do 127.", |
There was a problem hiding this comment.
Consider "číselnou" instead of "analogovou". Again, technically the value micro:bit receives is digital (because of ADC on the PIN). But what matters is that the returned value isn't just "boolean on/off" but an actual number.
Last, but not least, there's also the consistency with the MakeCode translation ("analog read pin" -> "číslo z pinu")
_locales/cs/maqueen-strings.json
Outdated
| "Maqueen_V5.SpeedGrade.speed5|block": "5", | ||
| "Maqueen_V5.Ultrasonic|block": "vzdálenost z ultrazvukového senzoru v cm", | ||
| "Maqueen_V5.Voltage.High|block": "vysoké", | ||
| "Maqueen_V5.Voltage.Low|block": "nízké", |
There was a problem hiding this comment.
I believe this will be used in the same way as maqueen.Voltage.Low, hence this translation is not correct. The question aimed at the DFRobot team is - why there's no V5 "on line tracking sensor" block available?
There was a problem hiding this comment.
I did not notice the enum was not used within the code at all. Good catch.
_locales/cs/maqueen-strings.json
Outdated
| "Maqueen_V5.SpeedGrade.speed4|block": "4", | ||
| "Maqueen_V5.SpeedGrade.speed5|block": "5", | ||
| "Maqueen_V5.Ultrasonic|block": "vzdálenost z ultrazvukového senzoru v cm", | ||
| "Maqueen_V5.Voltage.High|block": "vysoké", |
_locales/cs/maqueen-strings.json
Outdated
| "Maqueen_V5.NeoPixelColors.Green|block": "zelenou", | ||
| "Maqueen_V5.NeoPixelColors.Indigo|block": "indigo", | ||
| "Maqueen_V5.NeoPixelColors.Orange|block": "oranžovou", | ||
| "Maqueen_V5.NeoPixelColors.Purple|block": "fialovou", |
There was a problem hiding this comment.
I guess you accidentally swapped translations for Maqueen_V5.NeoPixelColors.Purple and Maqueen_V5.NeoPixelColors.Violet.
Violet = fialová (the rainbow colour)
Purple = purpurová OR (less common) nachová (as the redish/blueish/pinkish colour of clothes important / powerful people liked to wear in order to distinguish themselves).
_locales/cs/maqueen-strings.json
Outdated
| "Maqueen_V5.NeoPixelColors.Orange|block": "oranžovou", | ||
| "Maqueen_V5.NeoPixelColors.Purple|block": "fialovou", | ||
| "Maqueen_V5.NeoPixelColors.Red|block": "červenou", | ||
| "Maqueen_V5.NeoPixelColors.Violet|block": "purpurovou", |
There was a problem hiding this comment.
I guess you accidentally swapped translations for Maqueen_V5.NeoPixelColors.Purple and Maqueen_V5.NeoPixelColors.Violet.
Violet = fialová (the rainbow colour)
Purple = purpurová OR (less common) nachová (as the redish/blueish/pinkish colour of clothes important / powerful people liked to wear in order to distinguish themselves).
_locales/cs/maqueen-strings.json
Outdated
| "Maqueen_V5.CarLightColors.Blue|block": "modrou", | ||
| "Maqueen_V5.CarLightColors.Cyan|block": "azurovou", | ||
| "Maqueen_V5.CarLightColors.Green|block": "zelenou", | ||
| "Maqueen_V5.CarLightColors.Purple|block": "fialovou", |
There was a problem hiding this comment.
I don't have the maqueen v5 car to judge the actual colour, but purple is usually translated as purpurová. The "fialová" represents a different colour.
Considering the context where the NeoPixelColors.Purple defines it as red and blue mix (0xFF00FF), I'd say purpurová is proper translation.
Hey Peter. Thanks for your thorough review! Translating so much stuff was incredibly difficult and I was quite losing my mind amongst all the words 😊 Having another pair of eyes on this PR was much appreciated. I have incorporated all your suggestions and also removed my BLE changes. Not sure why they removed it during this PR waiting for the review. A pity. |
|
DFRobot guys, could you have a look? (@tangjie133 perhaps?). |
Hello, the DFRobot guys.
I have translated the Maqueen robot into Czech, for my son who will find the robot under the Christmas tree and I thought the community might appreciate the translation as well 😊
It was a surprisingly difficult task to do the translation right including method parameters.
I know I ask a lot, but I would appreciate your feedback, @almasy.
Below, find screenshots of all the translations. I thought it might make much more sense to visualise the translations for the review.
Maqueen v4 JS blocks
Maqueen v5 JS blocks
Maqueen v4 and v5 blocks